906338 - Remove old test framework

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

Is there some reason to keep the old framework other than that we have some test files using it?

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

No only reason we have it is a lot of tests that are written for it. Also if we remove old test framework we could probably slim down our test runner too.

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

To be clear I meant that many test are using old format.

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

I have submitted Bug 906916 on simplifying test runner code in general.

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Awesome, let's kill this then.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: bug

Also adds sdk/test/utils#waitUntil utility

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 810121 [details]
bug

Looks good, just a few nits.  Please address the nits in a new commit so that I can see the diff between the current commit and the changes.

Thanks!

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 810121 [details]
bug

Oh I guess I should r- for now, I'd like to review the nits once they are addressed too.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/9169ec64a96053cdbb725e62d9ca6aaa1ffc62a9
Bug 906338 refactor tests to using new assert lib, add test util
'waitUntil'

https://github.com/mozilla/addon-sdk/commit/c48c55e75c78f74b49b117c4f2bc1ebc84660eec
Merge pull request #1246 from jsantell/nuke-old-test-framework

Fix Bug 906338 Remove old test framework, r=@erikvold