906339 - Remove testing for "Automatic updates" on release builds

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/?tree=Try&rev=708ead144572 is current aurora pushed to try as though it were on beta. Note the rc2 failures, https://tbpl.mozilla.org/php/getParsedLog.php?id=26415724&tree=Try, where testSettingsMenuItems is trying to find the "Automatic updates" section which doesn't exist because on beta and below the custom updater is shut off.

Comment 1

[Chenxia Liu [:liuche]]

Attachment: Patch: Remove testing for "Automatic updates" on release builds

Try build (with patch from bug 903535, which needs something similar): https://tbpl.mozilla.org/?tree=Try&rev=b0d95219d095

I just added some build flag checks to the test, not sure if this is the right way to do branch-specific testing.

Comment 2

[Chenxia Liu [:liuche]]

Philor, what's the case where the Automatic updates setting is hidden? Your try pushes show "late beta" but I'd like to confirm that this is for all beta and release.

Comment 3

[Phil Ringnalda (:philor)]

It changes when the branding changes (EARLY_BETA_OR_EARLIER was just the tipmost thing in that try push, https://hg.mozilla.org/try/rev/c8d5855a9572 was the part that changed branding), both http://mxr.mozilla.org/mozilla-aurora/source/mobile/android/branding/beta/configure.sh and http://mxr.mozilla.org/mozilla-aurora/source/mobile/android/branding/official/configure.sh unset MOZ_UPDATER.

Comment 4

[Chenxia Liu [:liuche]]

Attachment: Patch: Remove testing for auto-update when not built

This patch depends on the patches from bug 900564 for conditional tests.

Comment 5

[Chenxia Liu [:liuche]]

Green try build when Automatic updates are not built: https://tbpl.mozilla.org/?tree=Try&rev=8e1023fe869f

Comment 6

[bhavana bajaj [:bajaj]]

low risk uplift when ready with risk evaluation and user impact should be good enough.Need not track it.

Comment 7

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/092d8cc931f8

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/092d8cc931f8

Comment 9

[Chenxia Liu [:liuche]]

Attachment: Aurora patch: remove testing for auto updates

Unless we want to uplift the test changes [1] from bug 900564, using #ifdefs seems like the most straightforward way to do conditional testing.

[1] https://hg.mozilla.org/mozilla-central/rev/7b5fe881c650

Comment 10

[Chenxia Liu [:liuche]]

Comment on attachment 796307 [details] [diff] [review]
Aurora patch: remove testing for auto updates

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Automatic updates is not built on beta/release
User impact if declined: Robocop testSettingsMenuItems will fail when 25 merges to beta
Testing completed (on m-c, etc.): locally tested
Risk to taking this patch (and alternatives if risky): low - just checks for a single declaration of a build flag
String or IDL/UUID changes made by this patch: none

Comment 11

[Chenxia Liu [:liuche]]

Landed on aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/6ec4a999aa87