906377 - [Messages] Guard against null placeholder errors when pressing Send

Status: RESOLVED DUPLICATE of bug 906581

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Rick Waldron [:rwaldron]]

Not quite the same as #904640 or #905950, but prevents TypeErrors from occurring when placeholders have been removed before a transitionend occurs after pressing Send (the result of a call to assimiliateRecipients when user presses Send)

leo+ because it's a regression.

Comment 1

[Rick Waldron [:rwaldron]]

What I meant was... "requesting" Leo+

Comment 2

[Rick Waldron [:rwaldron]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/11588

- Adds conditional guards to avoid TypeErrors when placeholders are null

Comment 5

[Julien Wajsberg [:julienw]]

please mark leo+ as dupes are leo+. Thanks !

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 791753 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/11588

Rick, do you think it's doable to do unit tests to cover this ? or is it meaningless ?

Comment 7

[Julien Wajsberg [:julienw]]

Comment on attachment 791753 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/11588

Just calling "visible" without children without any assert is enough for me (it shouldn't throw and that's what we want to check).

Comment 8

[Rick Waldron [:rwaldron]]

(In reply to Julien Wajsberg [:julienw] from comment #7)
> Comment on attachment 791753 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/11588
> 
> Just calling "visible" without children without any assert is enough for me
> (it shouldn't throw and that's what we want to check).

Sounds good, I'll get those added later today

Comment 9

[Rick Waldron [:rwaldron]]

This will be closable when https://bugzilla.mozilla.org/show_bug.cgi?id=906581 is resolved. 

(https://github.com/mozilla-b2g/gaia/pull/11635)

Comment 10

[Julien Wajsberg [:julienw]]

duping, we'll do that there after all.