Closed Bug 906403 Opened 7 years ago Closed 7 years ago

Some subconfigures fail in incremental builds when some flags like CFLAGS change

Categories

(Firefox Build System :: General, defect)

24 Branch
x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

When we change the value of e.g CFLAGS, subconfigure may fail with a message saying the value changed, and to either run make distclean or remove config.cache. This is annoying, especially on buildbots, where to unblock the slave, it needs a clobber, which can create more work than is probably necessary (adding, for example, a warning flag is not really a good reason to force a clobber).

With the wrapping from bug 903369, it's now possible to remove config.cache when we detect configure would fail, avoiding the failure.
Assignee: nobody → mh+mozilla
Comment on attachment 791789 [details] [diff] [review]
Avoid subconfigure fail in incremental builds when some variable like CFLAGS change

Review of attachment 791789 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/subconfigure.py
@@ +48,5 @@
> +# straighten things is to either run make distclean or config.cache. There's
> +# no reason not to do it automatically instead of failing, doing the cleanup
> +# (which, on buildbots means a full clobber), and restarting from scratch.
> +def maybe_clear_cache():
> +    import re

Nit: Import at file scope.
Attachment #791789 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/e616268dba3c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.