Closed
Bug 906503
Opened 11 years ago
Closed 11 years ago
Kill nsIExceptionProvider
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(1 file)
14.05 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
It's an annoying and not very useful indirection.
Attachment #791865 -
Flags: review?(bobbyholley+bmo)
Comment 1•11 years ago
|
||
Comment on attachment 791865 [details] [diff] [review] Patch v1 Review of attachment 791865 [details] [diff] [review]: ----------------------------------------------------------------- This is awesome! Combined with my patches in bug 901106, nsDOMScriptObjectFactory is pretty much obsolete. The only reason we need to instantiate it now (which I had to do explicitly: http://hg.mozilla.org/mozilla-central/rev/1c84d17d28fb ), is to register a shutdown observer that does some work. That stuff could certainly be moved elsewhere though - maybe even in mozilla::dom::ShutdownJSEnvironment? Can you file a followup on that work? ::: dom/base/nsDOMScriptObjectFactory.cpp @@ +47,2 @@ > // And pre-create the javascript language. > NS_CreateJSRuntime(getter_AddRefs(mJSRuntime)); This is gone now with my patches in bug 901106, so it will need some rebasing. ::: xpcom/base/nsExceptionService.cpp @@ -234,5 @@ > -NS_IMETHODIMP nsExceptionService::RegisterExceptionProvider(nsIExceptionProvider *provider, uint32_t errorModule) > -{ > - CHECK_SERVICE_USE_OK(); > - > - nsProviderKey key(errorModule); Please remove the definition is nsProviderKey earlier in the file.
Attachment #791865 -
Flags: review?(bobbyholley+bmo) → review+
Updated•11 years ago
|
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/24ac02f07c73
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•