906597 - loading a bug with an inactive-but-set tracking flag throws: Can't call method "sortkey" on an undefined value

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[:glob ✱]

loading a bug with an inactive-but-set tracking flag throws
  Can't call method "sortkey" on an undefined value.

this happens because is_active is passed to TrackingFlags::Flag::match(), which is then passed to the SUPER match(), so the inactive flags are never visible.

when the preload method loads the values, it creates a non-blessed hashref for bug_flag, resulting in the error.

Comment 1

[:glob ✱]

Attachment: 906597_1.patch

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 792046 [details] [diff] [review]
906597_1.patch

Review of attachment 792046 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

::: extensions/TrackingFlags/lib/Flag.pm
@@ +186,4 @@
>          $params->{'id'} = \@flag_ids;
>      }
>  
> +    # We need to return invactive flags if a value has been set

s/invactive/inactive/

Comment 3

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/TrackingFlags/lib/Flag.pm
Committed revision 8958.