Closed
Bug 906597
Opened 11 years ago
Closed 11 years ago
loading a bug with an inactive-but-set tracking flag throws: Can't call method "sortkey" on an undefined value
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: glob, Assigned: glob)
Details
Attachments
(1 file)
|
722 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
loading a bug with an inactive-but-set tracking flag throws Can't call method "sortkey" on an undefined value. this happens because is_active is passed to TrackingFlags::Flag::match(), which is then passed to the SUPER match(), so the inactive flags are never visible. when the preload method loads the values, it creates a non-blessed hashref for bug_flag, resulting in the error.
Attachment #792046 -
Flags: review?(dkl)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 792046 [details] [diff] [review] 906597_1.patch Review of attachment 792046 [details] [diff] [review]: ----------------------------------------------------------------- r=dkl ::: extensions/TrackingFlags/lib/Flag.pm @@ +186,4 @@ > $params->{'id'} = \@flag_ids; > } > > + # We need to return invactive flags if a value has been set s/invactive/inactive/
Attachment #792046 -
Flags: review?(dkl) → review+
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/ modified extensions/TrackingFlags/lib/Flag.pm Committed revision 8958.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: Extensions: TrackingFlags → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•