906603 - B2G RIL: Support Change Call Barring Password on Emulator.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[shawn ku [:sku]]

Support Change Call Barring Password on Emulator.

Currently, we always got error - RequestNotSupported when testing Change Call Barring Password on emulator. We migth need to make this test available on emulator.

Comment 1

[Ben Hsu [:HoPang]]

Attachment: Update the related testcase

Comment 2

[Szu-Yu Chen [:aknow] (inactive)]

Comment on attachment 8582279 [details] [diff] [review]
Update the related testcase

Review of attachment 8582279 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobileconnection/tests/marionette/test_call_barring_change_password.js
@@ +64,5 @@
> +      pin: "0000",
> +      newPin: "abcd"
> +    }))
> +
> +    // Test passing an incorrect password

Add a comment here to describe the default password in emulator.

Comment 3

[Ben Hsu [:HoPang]]

Attachment: Update the related testcase. r=aknow

Comment 4

[Ben Hsu [:HoPang]]

Attachment: [external/qemu] pull request 137

Comment 5

[Ben Hsu [:HoPang]]

Attachment: [hardware/ril] pull request 49 (For branch: b2g-ril_v7)

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 8592162 [details] [review]
[hardware/ril] pull request 49  (For branch: b2g-ril_v7)

Looks good, please also remember to provide a PR for master branch (for emulator KK). Thank you.

Comment 7

[Edgar Chen [:edgar]]

Comment on attachment 8591461 [details] [review]
[external/qemu] pull request 137

Looks good, thank you.

Comment 8

[Ben Hsu [:HoPang]]

Attachment: [hardware/ril] pull request 52 (For branch: master)

Comment 9

[Ben Hsu [:HoPang]]

Comment on attachment 8591461 [details] [review]
[external/qemu] pull request 137

Hi Edgar,

Since Bug 1152272 enhance the way emulator generate AT responses, there is one commit in this pull request is updated correspondingly. Can you take a look at it?

Comment 10

[Edgar Chen [:edgar]]

Comment on attachment 8591461 [details] [review]
[external/qemu] pull request 137

Perfect!! Thank you.

Comment 11

[Ben Hsu [:HoPang]]

Attachment: Update the related testcase (V2)

Hi Aknow,

There is another testcase in Telephony test suit need to be updated, do you minf reviewing this patch again?

Comment 12

[Szu-Yu Chen [:aknow] (inactive)]

Comment on attachment 8601443 [details] [diff] [review]
Update the related testcase (V2)

Review of attachment 8601443 [details] [diff] [review]:
-----------------------------------------------------------------

Good. Thank you.

::: dom/system/gonk/ril_consts.js
@@ +13,5 @@
>   * limitations under the License.
>   */
>  
>  // Set to true to debug all RIL layers
> +this.DEBUG_ALL = true;

should be false

::: dom/telephony/test/marionette/test_mmi_change_barring_password.js
@@ +40,5 @@
>      expectedError: {
>        name: "emMmiErrorInvalidPassword"
>      }
>    },
> +  // Expect to success.

succeed

Comment 13

[Ben Hsu [:HoPang]]

Attachment: Update the related testcase (V3)

Comment 14

[Ben Hsu [:HoPang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=df4b118172f0&exclusion_profile=false

Comment 15

[Edgar Chen [:edgar]]

I will help to check-in the patch.

Comment 16

[Edgar Chen [:edgar]]

platform_external_qemu:
- master: https://github.com/mozilla-b2g/platform_external_qemu/commit/218a5637399d023f4326e12c8a486dad95403b6c

Comment 17

[Edgar Chen [:edgar]]

platform_hardware_ril:
- master: https://github.com/mozilla-b2g/platform_hardware_ril/commit/42f61f665e7a9857da8cd14b455e15bae98e6b44
- b2g-ril_v7: https://github.com/mozilla-b2g/platform_hardware_ril/commit/22664edc4c73e5fe8f5095ff1d5549db78a2bc10

Comment 18

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/eee8b4559002

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eee8b4559002