906633 - Scratchpad does not set mimetype for open/save dialogs

Status: RESOLVED FIXED

(DevTools Graveyard :: Scratchpad, enhancement)

Description

[Eldmannen]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20130818030219

Steps to reproduce:

Opened Scratchpad. (Shift-F4).
Went to File->Open File..., or File->Save As...


Actual results:

File dialog showed all files.


Expected results:

File dialog should only show .js files, and files with application/javascript mimetype.

Comment 1

[Brandon Benvie [:benvie]]

Attachment: bug-906633.patch

Adds filters for JavaScript Files/All Files to Save As and Open File dialogs.

Comment 2

[Eldmannen]

Not sure it makes sense to add non-JavaScript files.
Here are file extensions for reference.

Coco - .co
CoffeeScript - .coffee
Dart - .dart
GorillaScript - .gs
Ham - .ham
Kaffeine - .k
TypeScript - .ts

Comment 3

[Eldmannen]

Mimetype of interest are;
text/*
application/*

Comment 4

[Eldmannen]

It is conceivable someone may want to open JSON files (extension: .json, mimetype: application/json).
For things such as minification/prettyprinting.

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 810752 [details] [diff] [review]
bug-906633.patch

Review of attachment 810752 [details] [diff] [review]:
-----------------------------------------------------------------

alrighty.

Comment 6

[Brandon Benvie [:benvie]]

Eldamannen, I think json might make sense but I don't think the rest do since you can't run them in the Scratchpad. The Scratchpad isn't really meant to be a general purpose code editor.

Comment 7

[Brandon Benvie [:benvie]]

Attachment: bug-906633.patch

Adds *.json. https://tbpl.mozilla.org/?tree=Try&rev=9dee770f9c8b

Comment 8

[Brandon Benvie [:benvie]]

Retry since tree was broken. https://tbpl.mozilla.org/?tree=Try&rev=bf2ece7866f1

Comment 9

[Brandon Benvie [:benvie]]

Different trychoose syntax.  https://tbpl.mozilla.org/?tree=Try&rev=01bd712a3e8b

Comment 10

[Brandon Benvie [:benvie]]

https://hg.mozilla.org/integration/fx-team/rev/d0f3d527250e

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d0f3d527250e