90666 - Make ImportCharSet::m_Ascii strong

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[Colin Blake]

ImportCharSet::m_Ascii, defined in mailnews/import/src/ImportCharSet.cpp, is
defined as a weak symbol on OpenVMS. This causes a problem when I perform a
static build because the linker can't find the symbol (referenced in 
nsImportTranslator).

In order to get the compiler to generate a strong symbol I need to give it
a value. Attached is a patch. If someone will review/approve, I'll check
it in.

Comment 1

[Colin Blake]

Attachment: Patch to make symbol strong

Comment 2

[Colin Blake]

Almost three months since I posted this bug and patch, and I'm still waiting for 
a review (or a comment of some sort).

cc'ing sspitzer as another possible source of review.

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 42180 [details] [diff] [review]
Patch to make symbol strong

r/sr=sspitzer

Comment 4

[Colin Blake]

Checked in. Marking fixed.

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

lxr says:

1.5 colin%theblakes.com Oct 29 13:14   This comment really goes with the last 
checkin whose comment I fat-fingered.
Add an initialiser to ImportCharSet::m_Ascii so that it becomes a strong
symbol and therefore visible to the OpenVMS linker.
b=90666 r/sr=sspitzer
 
1.4 colin%theblakes.com Oct 29 12:07   ImportCharSet::m_AsciiImportCharSet.cpp