906664 - [Fig] Make the text for the bookmark placeholders a bit more explicit

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Marco Zehe (:MarcoZ)]

Right now, it says "Add a bookmark", which could easily be mistaken for a button label that actually adds a bookmark. The text should reflect the fact that this is a placeholder where a bookmark added to the awesome screen will be shown in the future.

Comment 1

[Ian Barlow (:ibarlow)]

I don't really understand the issue here. 

You can tap the placeholder thumbnail, which brings you to some UI to enter the URL of the page you would like to add. 

So it actually is meant to communicate "add a bookmark to this spot". 

Is that not happening right now? Because if it isn't, we should update the subject of this bug to fix that, because that's a bigger problem.

Comment 2

[Aaron Train [:aaronmt]]

Sounds like this would be solved with a first-time tutorial or something similar

Comment 3

[Ian Barlow (:ibarlow)]

You could be right. But I first want to understand whether the interaction is working to begin with... I could be assuming too much, but a box with a "+" in it with a label underneath that reads "Add a bookmark" seems pretty explicit already. http://cl.ly/image/2J472I3m0s26

Comment 4

[:Margaret Leibovic]

I think the issue is that you don't actually tap on that text to add the bookmark, you tap on the thumbnail placeholder with the "+" in it.

Marco, is there a content description on that placeholder? Would that make things clearer?

Comment 5

[Marco Zehe (:MarcoZ)]

OK, here's how this bug came about:
1. I was exploring the Fig build. I had just launched it and was exploring the new start page.
2. This is what I saw:
a) At the top left of the main area, not counting the toolbar above, "Firefox: Support" and "Firefox: Customize with add-ons".
b) Below that, four items which said "Add a bookmark", arranged in two rows with two items each.
c) Below that, "Firefox: About your browser", plus its URL, and to the right, "Firefox: Customize with add-ons", plus its URL.
3. I then went onto IRC #mobile and asked Lucas what these four identical items "Add a bookmark" were. Lucas told me that these were spots where custom bookmarks would appear once they were added.
4. I then went ahead with filing this bug to make it clearer that these are placeholders rather than buttons.

So if there are additional items here, they a) do not have a contentDescription and b) aren't even reachable by swiping to the right continuously with TalkBack. Normally, unlabeled images are reachable and speak something like "graphic 60 button" or something similar, so one knows that there are at least unlabeled items there.

So if you are telling me that there are additional things that should be reached, then they are not seen by TalkBack.

Comment 6

[:Margaret Leibovic]

Marco, thanks for the detailed report.

Another question: What do you find on the current about:home on nightly or release? This new UI is similar to the content of the "Top sites" section on the current about:home, so if we do that correctly, we should look at the code on mozilla-central to see what we do there.

On mozilla-central, we only show the "+" placeholder image without the "Add a bookmark" label, so maybe those placeholders are completely inaccessible right now :( However, these placeholder images will only appear if you have a profile with fewer than 6 bookmark/history items, so this case is pretty rare.

Comment 7

[Max Li [:maxli]]

(In reply to :Margaret Leibovic from comment #6)
> Another question: What do you find on the current about:home on nightly or
> release? 

The current nightly builds unfortunately have no description at all for the placeholders.


Also, to clarify from comment 4, TalkBack makes you land on the container containing both the placeholder and the text. So the control you interact with does have the "Add a Bookmark" text.

Comment 8

[:Margaret Leibovic]

I just turned on TalkBack, and it seems like this issue is resolved now. Exploring the thumbnail area, empty thumbnails say "Add a site" which is correct.

Marco, is this still a problem for you on Nightly/Aurora?

Comment 9

[Marco Zehe (:MarcoZ)]

Nope, this is much better now. Thanks! Closing as WorksForMe.