906668 - [fig] Reading list text is cut off on small screens

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

On a galaxy q in landscape mode:
1. Start Figgy fennec (I'm actually using kbrosnan's armv6 build)
2. Rotate device to landscape
3. Swipe on the about:home over to the reading list

Actual: the main text ("Articles you save for later show up here") is cut off because of the small screen. That part of the screen is not scrollable either so there's no way to read the text without going back into portrait.

For some reason screenshotting isn't working on the device but if you want a pic let me know.

Comment 1

[Chenxia Liu [:liuche]]

Attachment: Screenshot: reading list empty screen on small screen

We're using compound drawables + spacers in reading list, which we are not in the other empty pages. For some reason, on small screens, the linear layout isn't resizing the weights correctly. Will investigate further.

Comment 2

[Lucas Rocha (:lucasr)]

Maybe we should actually adapt our layouts for small screens. i.e. alternative layouts and/or images.

Comment 3

[Chenxia Liu [:liuche]]

Attachment: Patch: Restyle reading list to fix cropping

Sorry man, I couldn't keep the TextView drawable :(

Comment 4

[Chenxia Liu [:liuche]]

Attachment: Screenshot: FIXED reading list empty screen on small screen

Screenshot with patch applied on DroidX (which had cut-off problems before).

Comment 5

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 796146 [details] [diff] [review]
Patch: Restyle reading list to fix cropping

Review of attachment 796146 [details] [diff] [review]:
-----------------------------------------------------------------

This might be working for that particular screen. Still I see the "y" touching the line. We might need some other way of handling this. But for now, I guess, we can land this.

Comment 6

[Chenxia Liu [:liuche]]

Changed text weight from 2 to 3, so text doesn't touch the bottom line anymore.

https://hg.mozilla.org/integration/fx-team/rev/b1c7422727e2

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b1c7422727e2