906681 - Fix imported target path and state of paused downloads

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[:Paolo Amadini]

In the new DownloadImport module, paused downloads were imported into a state
from which they couldn't be restarted, and with the URI path instead of the
file path for the target.

Comment 1

[:Paolo Amadini]

Attachment: bug-906681.diff

This fixes this issue, and also prevents downloads that never started from being
restored in a stopped state. This is done by never serializing "stopped" but
only the "succeeded", "canceled", and "error" properties.

Comment 2

[Neil Deakin]

Comment on attachment 792207 [details] [diff] [review]
bug-906681.diff

>   let propertiesToDeserialize = [
>+    "succeeded",
>+    "canceled",
>+    "error",
>     "startTime",
>     "totalBytes",
>     "hasPartialData",
>     "tryToKeepPartialData",
>     "launcherPath",
>     "launchWhenSucceeded",
>     "contentType",
>   ];
> 

Would it be worth it to define this list once and shared with toSerializable since the list is the same except for "error"?

Comment 3

[:Paolo Amadini]

Attachment: Updated patch

Comment 4

[:Paolo Amadini]

https://hg.mozilla.org/integration/fx-team/rev/5f42d98b068b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5f42d98b068b

Comment 6

[Mihaela Velimiroviciu (:mihaelav)]

Do you have a scenario which reproduced the issue? I tried the following steps:
1. Launch an older version of Firefox (prior of landing the Downloads.jsm) - e.g. August the 5th Nightly
2. Start downloading a large file
3. Pause the download
4. Close Firefox
5. Launch a Firefox version which uses Downloads.jsm (I used August 18 Nightly), using the same profile as in step 1
6. Open the Downloads Panel, right click on the paused download (from step 3) and resume the download

Result: Download is successfully resumed.

When was the DownloadImport module introduced?

Comment 7

[:Paolo Amadini]

The steps to reproduce look good, with the addition that to reproduce the original issue the full target path (directory or file name) of the download should contain spaces (or other special characters that are percent-encoded in URLs). This is usually true on Windows with default user profile paths.

The DownloadImport module was first introduced in bug 851466.