906698 - On big-endian processor, nsUTF16ToUnicodeBase::UTF16ConvertToUnicode is mis-converting UTF16 data

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[t_mrc-ct]

Attachment: last few lines of test_singlebytes.js log (because it is tooooo long)

User Agent: Mozilla/5.0 (Macintosh; PPC Mac OS X 10.5; rv:17.0) Gecko/20130805 Firefox/17.0 TenFourFox/G5 (Nightly/Aurora)
Build ID: 20130805171245

Steps to reproduce:

On TenFourFox 22 with --enable-tests build config.
Run xpcshell-tests 


Actual results:

dom/encoding/test/unit/test_singlebytes.js unit test failied.


Expected results:

test passed without failure.

Comment 1

[t_mrc-ct]

Attachment: patch for intl/uconv/ucvlatin/nsUTF16ToUnicode.cpp

Before bitwise-or, (*src++) is implicitly cast to int16_t.
If src has negative value, upper byte of casted src is 0xff.
It mask upper byte of u.

this patch prevent it.

Comment 2

[mjh563]

Thanks for the patch! You should ask someone to review it though, otherwise it's likely to get ignored.

I suggest that you request a review from :smontagu, as he's previously worked on this code.

The patch review and submission process is explained in more detail here:
https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch

Comment 3

[t_mrc-ct]

Comment on attachment 792229 [details] [diff] [review]
patch for intl/uconv/ucvlatin/nsUTF16ToUnicode.cpp

Thank you for your information. 

I request review to :smontagu.

Comment 4

[Simon Montagu :smontagu]

Comment on attachment 792229 [details] [diff] [review]
patch for intl/uconv/ucvlatin/nsUTF16ToUnicode.cpp

Review of attachment 792229 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks!

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
for how to upload a new patch file and add the checkin-needed keyword to get this checked in.

Comment 6

[t_mrc-ct]

Attachment: Bug 906698 - nsUTF16ToUnicode is mis-converting on big-endian processor

fix patch format.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 793478 [details] [diff] [review]
Bug 906698 - nsUTF16ToUnicode is mis-converting on big-endian processor

You don't need to re-request review when all that's changing is the patch format.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2654e3d27d41

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2654e3d27d41