Closed Bug 906711 Opened 8 years ago Closed 8 years ago

Search buttons don't indicate the search engine

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: maxli, Assigned: maxli)

References

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

(This isn't Fig specific, but I'm marking it as blocking the meta bug because it seems to be the same area of code; feel free to change if I shouldn't have done this.)

I noticed that the search buttons for the search suggestions on the awesomescreen don't indicate the search provider when using a screen reader, so you end up with several indistinguishable buttons labelled only with the search query. (And you can't even land on the icons to tell what the search provider is.)
OS: All → Android
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → maxli
Attachment #794117 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 794117 [details] [diff] [review]
Patch

Review of attachment 794117 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/SearchEngineRow.java
@@ +155,4 @@
>      }
>  
>      public void setSearchTerm(String searchTerm) {
>          mUserEnteredTextView.setText(searchTerm);

nit: add empty line here.

@@ +188,5 @@
>          // Add additional suggestions given by this engine
>          final int recycledSuggestionCount = mSuggestionView.getChildCount();
>          final int suggestionCount = mSearchEngine.suggestions.size();
>  
>          for (int i = 0; i < suggestionCount; i++) {

Shouldn't you do the same on all suggestions here?
Comment on attachment 794117 [details] [diff] [review]
Patch

Review of attachment 794117 [details] [diff] [review]:
-----------------------------------------------------------------

Just setting r- to send proper notification.
Attachment #794117 - Flags: review?(lucasr.at.mozilla) → review-
Attached patch Patch v2Splinter Review
(In reply to Lucas Rocha (:lucasr) from comment #2)

> Shouldn't you do the same on all suggestions here?

I do that in setSuggestionOnView, I can move it down directly into the for loop if you want.
Attachment #794117 - Attachment is obsolete: true
Attachment #794674 - Flags: review?(lucasr.at.mozilla)
Attachment #794674 - Flags: review?(lucasr.at.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/9459d5c2e605
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.