906711 - Search buttons don't indicate the search engine

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Max Li [:maxli]]

(This isn't Fig specific, but I'm marking it as blocking the meta bug because it seems to be the same area of code; feel free to change if I shouldn't have done this.)

I noticed that the search buttons for the search suggestions on the awesomescreen don't indicate the search provider when using a screen reader, so you end up with several indistinguishable buttons labelled only with the search query. (And you can't even land on the icons to tell what the search provider is.)

Comment 1

[Max Li [:maxli]]

Attachment: Patch

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 794117 [details] [diff] [review]
Patch

Review of attachment 794117 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/SearchEngineRow.java
@@ +155,4 @@
>      }
>  
>      public void setSearchTerm(String searchTerm) {
>          mUserEnteredTextView.setText(searchTerm);

nit: add empty line here.

@@ +188,5 @@
>          // Add additional suggestions given by this engine
>          final int recycledSuggestionCount = mSuggestionView.getChildCount();
>          final int suggestionCount = mSearchEngine.suggestions.size();
>  
>          for (int i = 0; i < suggestionCount; i++) {

Shouldn't you do the same on all suggestions here?

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 794117 [details] [diff] [review]
Patch

Review of attachment 794117 [details] [diff] [review]:
-----------------------------------------------------------------

Just setting r- to send proper notification.

Comment 4

[Max Li [:maxli]]

Attachment: Patch v2

(In reply to Lucas Rocha (:lucasr) from comment #2)

> Shouldn't you do the same on all suggestions here?

I do that in setSuggestionOnView, I can move it down directly into the for loop if you want.

Comment 5

[Max Li [:maxli]]

https://hg.mozilla.org/integration/fx-team/rev/9459d5c2e605

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9459d5c2e605