906734 - Put TestHarness.h profile directories under runcppunittest's temp directory

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[(not currently active) Ted Mielczarek]

runcppunittests.py creates a temp directory (and cleans it up) per-test, so there's no reason TestHarness.h shouldn't be putting its profile directory there. This is causing bug 874642 because profile directories are piling up on the build slaves.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Put TestHarness.h profile directories under runcppunittest's temp directory

Comment 2

[Ed Morley [:emorley]]

Thank you :-)

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 792246 [details] [diff] [review]
Put TestHarness.h profile directories under runcppunittest's temp directory

Review of attachment 792246 [details] [diff] [review]:
-----------------------------------------------------------------

<Waldo> ted: hm, so this means you kind of have to use the harness to run C++ tests, and you can't run them individually so much any more?
<ted> Waldo: yes
<Waldo> ted: do we not have code nuking the profile directory after XPCOM shutdown, then?
<ted> Waldo: apparently not
<ted> Waldo: i'd prefer to handle that in python
<ted> since we already have a temp dir there, and that also does the cleanup if the test crashes or whatever
<Waldo> makes sense
<Waldo> would be nice if we did both, perhaps, but that's probably a little overkill for the manual-running case

In any case, this seems good enough even if doing that extra bit would be nice for completeness.

Comment 4

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/feb98bbaaf87

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/feb98bbaaf87

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/34b2938a8dde
https://hg.mozilla.org/releases/mozilla-beta/rev/af82c387aced