Closed Bug 906734 Opened 7 years ago Closed 7 years ago

Put TestHarness.h profile directories under runcppunittest's temp directory

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(firefox24 fixed, firefox25 fixed, firefox26 fixed)

RESOLVED FIXED
mozilla26
Tracking Status
firefox24 --- fixed
firefox25 --- fixed
firefox26 --- fixed

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

runcppunittests.py creates a temp directory (and cleans it up) per-test, so there's no reason TestHarness.h shouldn't be putting its profile directory there. This is causing bug 874642 because profile directories are piling up on the build slaves.
Blocks: 874642
Thank you :-)
Comment on attachment 792246 [details] [diff] [review]
Put TestHarness.h profile directories under runcppunittest's temp directory

Review of attachment 792246 [details] [diff] [review]:
-----------------------------------------------------------------

<Waldo> ted: hm, so this means you kind of have to use the harness to run C++ tests, and you can't run them individually so much any more?
<ted> Waldo: yes
<Waldo> ted: do we not have code nuking the profile directory after XPCOM shutdown, then?
<ted> Waldo: apparently not
<ted> Waldo: i'd prefer to handle that in python
<ted> since we already have a temp dir there, and that also does the cleanup if the test crashes or whatever
<Waldo> makes sense
<Waldo> would be nice if we did both, perhaps, but that's probably a little overkill for the manual-running case

In any case, this seems good enough even if doing that extra bit would be nice for completeness.
Attachment #792246 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/feb98bbaaf87
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.