Closed Bug 906748 Opened 11 years ago Closed 11 years ago

[Messages] We don't see the cursor when we remove a "number" recipient

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:koi+)

RESOLVED FIXED
blocking-b2g koi+

People

(Reporter: julienw, Assigned: rwaldron)

Details

Attachments

(1 file)

STR:
* add a recipient with numbers (press 123456 then enter)
* remove it by pressing backspace

Expected:
* we still see the cursor

Actual:
* we don't see the cursor, even if we lose the focus and tap the recipients panel again
This is likely because the placeholder is in "zero-width" mode, which was implemented here https://github.com/mozilla-b2g/gaia/commit/deeba30eb02ae1286ba277edb8f681c85bee1ca0
Sorry, forgot to add that it will only expand once the user starts typing. Here's the bug: https://bugzilla.mozilla.org/show_bug.cgi?id=887712
in Bug 887712 comment 14 Corey was saying that we see the blank line when it's focused, and I perfectly agree with this. However, when it's focused, we should see the cursor :) Therefore when it's focused it should not be zero-width.

Does that make sense ?
(In reply to Julien Wajsberg [:julienw] from comment #3)
> in Bug 887712 comment 14 Corey was saying that we see the blank line when
> it's focused, and I perfectly agree with this. However, when it's focused,
> we should see the cursor :) Therefore when it's focused it should not be
> zero-width.
> 
> Does that make sense ?

Oh yes, makes complete sense, but will still break bug 887712 :(
Are you sure of this ? It seems to me that Ayman was ok with having the blank line when we're in edit mode. (as opposed to _not_ have that blank line when we're not focused, what bug 887712 was fixing).

Ayman, would you please confirm or invalidate ?
Flags: needinfo?(aymanmaat)
When there is enough contacts to fill a row, the app used to slide the row up out of the way—because the cursor element's width would make that line too long, focused or not. I can't think of a way to know where the cursor/placeholder element currently is in the recipient list to make special cased rules for display, except for the case where there are _no_ recipients (add 1, delete it)
Yep but as I say (maybe I'm not clear enough ?) I think Ayman didn't see a problem to slide the row up out of the way _while we are editing_. Of course the placeholder needs to be zero-width when we're not editing anymore.
(In reply to Julien Wajsberg [:julienw] from comment #5)
> Are you sure of this ? It seems to me that Ayman was ok with having the
> blank line when we're in edit mode. (as opposed to _not_ have that blank
> line when we're not focused, what bug 887712 was fixing).
> 
> Ayman, would you please confirm or invalidate ?

(In reply to Julien Wajsberg [:julienw] from comment #7)
> Yep but as I say (maybe I'm not clear enough ?) I think Ayman didn't see a
> problem to slide the row up out of the way _while we are editing_. Of course
> the placeholder needs to be zero-width when we're not editing anymore.

Yep i confirm you are right twice Julien. There is no problem to slide the row up out of the way _while we are editing_ ...and return it back when we are not.

We absolutely must show the cursor in the 'to field' when focus is there... if we do not do that the user is disorientated as they have no idea which field is in focus until they type something. Thats not an acceptable UX
Flags: needinfo?(aymanmaat)
blocking-b2g: --- → koi?
(In reply to ayman maat :maat from comment #8)
> (In reply to Julien Wajsberg [:julienw] from comment #5)
> > Are you sure of this ? It seems to me that Ayman was ok with having the
> > blank line when we're in edit mode. (as opposed to _not_ have that blank
> > line when we're not focused, what bug 887712 was fixing).
> > 
> > Ayman, would you please confirm or invalidate ?
> 
> (In reply to Julien Wajsberg [:julienw] from comment #7)
> > Yep but as I say (maybe I'm not clear enough ?) I think Ayman didn't see a
> > problem to slide the row up out of the way _while we are editing_. Of course
> > the placeholder needs to be zero-width when we're not editing anymore.
> 
> Yep i confirm you are right twice Julien. There is no problem to slide the
> row up out of the way _while we are editing_ ...and return it back when we
> are not.
> 
> We absolutely must show the cursor in the 'to field' when focus is there...
> if we do not do that the user is disorientated as they have no idea which
> field is in focus until they type something. Thats not an acceptable UX
Assignee: nobody → waldron.rick
Sorry about that...
- If nothing "typed" on keyup, assume isDeletingRecipient
- Updates unrelated test in thread_ui
Attachment #795653 - Flags: review?(felash)
Comment on attachment 795653 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/11766

r=me

thanks !
Attachment #795653 - Flags: review?(felash) → review+
gaia@master https://github.com/mozilla-b2g/gaia/commit/56b32c8efa2d81c40cf7256b927c0b408f9d58f0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
blocking-b2g: koi? → koi+
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: