906868 - Use collections to populate featured apps

Status: RESOLVED DUPLICATE of bug 901710

(Marketplace Graveyard :: API, defect, P1)

Description

[Christopher Van Wiemeersch [:cvan]]

Now that featured apps are being populated from a collection, the API should return those. Waffle this behind the `rocketfuel` switch; if it's disabled we should be pulling from the existing `FeaturedApp*` models as we do today.

Basta, correct me if I'm wrong, but this is the specificity of the collections we should be pooling from when given a carrier, region, and page combination?

1. Carrier-Region-Page
2. Region-Page
3. Page

Comment 1

[Matt Basta [:basta]]

1. Carrier-Region-Page
2. Carrier-Page
3. Region-Page
3. Page

Let me know if that's stupid.

https://docs.google.com/document/d/1eavZOuS0v3i_5wK7xORJhYZI01keEiC3Vfp0mj080U8/edit#

Comment 2

[Mathieu Pillard [:mat]]

When implementing bug 903489 I did the following:
1. Carrier-Region-Category
2. Region-Category
3. Category

This will require some tweaking, since the system I put in place was quite dumb, it was simply removing filters in a specific order.

Comment 3

[Matt Basta [:basta]]

If it makes your life easier, we don't need to implement this in the rocketfuel API. This is only really necessary in the consumer APIs.

Comment 4

[Mathieu Pillard [:mat]]

Ok, it was good to play with that in the rocketfuel API while we didn't have implemented this in the consumer part anyway. 

It's likely the implementation will stay similar, we'll just move this away from rocketfuel to consumer and tweak it to match your algorithm.

Comment 5

[Matt Basta [:basta]]

Cool, thanks

Comment 6

[Mathieu Pillard [:mat]]

Note: if we intend to re-use the API code used for rocketfuel in consumer-facing APIs, then we'll need to fix bug 905160 and bug 907820.

Comment 7

[Chuck Harmston [:chuck]]

For Q3 it's probably not worth considering consumer-facing APIs, as the only ones created will be via rocketfuel.

Comment 8

[Mathieu Pillard [:mat]]

Yeah, I meant the Featured Apps API and everything that's going to be reading collections from fireplace. To me that's consumer-facing API.

Comment 9

[Mathieu Pillard [:mat]]

bug 901710 will re-use the Collection API in WithFeaturedResource search API, keeping this bug opened because I need to work on its dependencies and also adjust the fallback filter per comment #1

Comment 10

[Mathieu Pillard [:mat]]

Actually let's dupe it, both are really about the same thing. I'll open up a new bug for the fallback filter tweaks.