Closed Bug 906910 Opened 7 years ago Closed 7 years ago

[MP] Defect - Top sites can not be deleted if Metro is closed after removal

Categories

(Firefox for Metro Graveyard :: Browser, defect, P2)

x86
Windows 8.1
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 26

People

(Reporter: Samvedana, Assigned: jimm)

References

Details

(Whiteboard: [preview] feature=defect c=testing u=developer p=1)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130819030205
Built from http://hg.mozilla.org/mozilla-central/rev/c8c9bd74cc40

Steps to reproduce:
1. Remove several tiles from "Top Sites" 
2. Close Firefox Metro

Expected: 
The removed tiles should not be reloaded when re-opening Firefox Metro

Actual:
The removed tiles were reloaded when re-opening Firefox Metro
Video is available at  http://youtu.be/c2Q0hcaOFPw
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0 → [preview-triage] feature=defect c=tbd u=tbd p=1
Attached patch fixSplinter Review
The close code in here never gets called, so I've removed. When we shutdown we always force close, so the onclose handler is ignored.
Assignee: nobody → jmathies
Attachment #792845 - Flags: review?(sfoster)
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Summary: Defect - Top sites can not be deleted if Metro is closed after removal → [MP] Defect - Top sites can not be deleted if Metro is closed after removal
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=1 → [preview] feature=defect c=testing u=developer p=1
Comment on attachment 792845 [details] [diff] [review]
fix

Review of attachment 792845 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good
Attachment #792845 - Flags: review?(sfoster) → review+
https://hg.mozilla.org/mozilla-central/rev/83254f71904c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Mozilla/5.0 (Windows NT 6.2; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130827030201

WFM
Tested on Windows 8 32bit using latest Nightly for iteration #13 and following the steps to reproduce from comment 0.
Status: RESOLVED → VERIFIED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.