Closed Bug 906918 Opened 6 years ago Closed 6 years ago

Use MoveRef's in nsTHashtable

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: justin.lebar+bug, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

See patch in a moment.
This patch adds a move constructor for nsTHashtable and also lets
nsTHashtable use its EntryType's move constructor, if one is available.

This patch also adds move constructors for nsCharPtrHashKey and
nsUnicharPtrHashKey.  Using these new constructors, nsTHashtable will be
able to avoid strdup()'ing all of its keys whenever it resizes the
table.
Attachment #792471 - Flags: review?(benjamin)
Attachment #792471 - Flags: review?(benjamin) → review+
Waldo et al., thanks a lot for moving Move into mfbt.  This is a really powerful abstraction.
I see what you did there.
https://hg.mozilla.org/mozilla-central/rev/7b925807955c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Hmm, can we use C++11 move() here as well?
You need to log in before you can comment on or make changes to this bug.