Use MoveRef's in nsTHashtable

RESOLVED FIXED in mozilla26

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: justin.lebar+bug, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
mozilla26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
See patch in a moment.
(Reporter)

Comment 1

5 years ago
Created attachment 792471 [details] [diff] [review]
Use MoveRef's in nsTHashtable.

This patch adds a move constructor for nsTHashtable and also lets
nsTHashtable use its EntryType's move constructor, if one is available.

This patch also adds move constructors for nsCharPtrHashKey and
nsUnicharPtrHashKey.  Using these new constructors, nsTHashtable will be
able to avoid strdup()'ing all of its keys whenever it resizes the
table.
Attachment #792471 - Flags: review?(benjamin)

Updated

5 years ago
Attachment #792471 - Flags: review?(benjamin) → review+
(Reporter)

Comment 2

5 years ago
Waldo et al., thanks a lot for moving Move into mfbt.  This is a really powerful abstraction.

Comment 3

5 years ago
I see what you did there.
https://hg.mozilla.org/mozilla-central/rev/7b925807955c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26

Comment 6

5 years ago
Hmm, can we use C++11 move() here as well?
You need to log in before you can comment on or make changes to this bug.