906940 - Exactly root IsAcceptableThis

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: handlify_IsAcceptableThis_callback-js-v0.diff

IsAccpetableThis is an indirectly call template parameter, which ends up dispatching to a templatized method. I am not confident that our analysis -- or myself for that matter -- is sufficient to catch any hazards here, so I changed the type to verify. I didn't end up needing to add any roots for opt builds, so I figure we might as well keep the patch.

Comment 1

[Terrence Cole [:terrence]]

Attachment: handlify_IsAcceptableThis_callback-browser-v0.diff

https://tbpl.mozilla.org/?tree=Try&rev=c58c4b95c033

Comment 2

[Jon Coppeard (:jonco)]

Comment on attachment 792495 [details] [diff] [review]
handlify_IsAcceptableThis_callback-js-v0.diff

Review of attachment 792495 [details] [diff] [review]:
-----------------------------------------------------------------

Looks nice!

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 792499 [details] [diff] [review]
handlify_IsAcceptableThis_callback-browser-v0.diff

ValueHasISupportsPrivate(JSContext* cx, const JS::Value& aVal)
JSContext* aCX

The method is a bit ugly, but ok since it is debug only.

Comment 4

[Terrence Cole [:terrence]]

Yeah, I wish there were an easier way to go from a Value to a GCThing pointer.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6eaf9e414a52

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6eaf9e414a52