Closed Bug 906940 Opened 7 years ago Closed 7 years ago

Exactly root IsAcceptableThis

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(2 files)

IsAccpetableThis is an indirectly call template parameter, which ends up dispatching to a templatized method. I am not confident that our analysis -- or myself for that matter -- is sufficient to catch any hazards here, so I changed the type to verify. I didn't end up needing to add any roots for opt builds, so I figure we might as well keep the patch.
Attachment #792495 - Flags: review?(jcoppeard)
Attachment #792499 - Flags: review?(continuation) → review?(bugs)
Comment on attachment 792495 [details] [diff] [review]
handlify_IsAcceptableThis_callback-js-v0.diff

Review of attachment 792495 [details] [diff] [review]:
-----------------------------------------------------------------

Looks nice!
Attachment #792495 - Flags: review?(jcoppeard) → review+
Comment on attachment 792499 [details] [diff] [review]
handlify_IsAcceptableThis_callback-browser-v0.diff

ValueHasISupportsPrivate(JSContext* cx, const JS::Value& aVal)
JSContext* aCX

The method is a bit ugly, but ok since it is debug only.
Attachment #792499 - Flags: review?(bugs) → review+
Yeah, I wish there were an easier way to go from a Value to a GCThing pointer.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6eaf9e414a52
https://hg.mozilla.org/mozilla-central/rev/6eaf9e414a52
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.