Closed
Bug 906971
Opened 12 years ago
Closed 12 years ago
Clean up editcerts.js
Categories
(Core Graveyard :: Security: UI, defect)
Core Graveyard
Security: UI
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
Details
Attachments
(1 file)
|
5.11 KB,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
All the clean up deferred from Bug 825583:
- Remove commented out code
- Removed unused vars
- Remove trailing spaces
- Fix alignment issues
I also want to change '0's to nsIX509CertDB.UNTRUSTED as appropriate, but I'm not sure now if that should be done.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #792533 -
Flags: review?(dkeeler)
|
|
||
Comment 2•12 years ago
|
||
Comment on attachment 792533 [details] [diff] [review]
Proposed Patch v1
Review of attachment 792533 [details] [diff] [review]:
-----------------------------------------------------------------
In bug 825583 comment 14, Brian says: "The other changes are good". r=me
(In reply to Cykesiopka from comment #0)
> I also want to change '0's to nsIX509CertDB.UNTRUSTED as appropriate, but
> I'm not sure now if that should be done.
I would wait on this - I think those sorts of things can be done when we do the certificate manager UI refresh.
Attachment #792533 -
Flags: review?(dkeeler) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
(In reply to David Keeler (:keeler) from comment #2)
> I would wait on this - I think those sorts of things can be done when we do
> the certificate manager UI refresh.
Ok, thanks.
|
||
Comment 4•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•