906971 - Clean up editcerts.js

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[:Cykesiopka]

All the clean up deferred from Bug 825583:
- Remove commented out code
- Removed unused vars
- Remove trailing spaces
- Fix alignment issues

I also want to change '0's to nsIX509CertDB.UNTRUSTED as appropriate, but I'm not sure now if that should be done.

Comment 1

[:Cykesiopka]

Attachment: Proposed Patch v1

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 792533 [details] [diff] [review]
Proposed Patch v1

Review of attachment 792533 [details] [diff] [review]:
-----------------------------------------------------------------

In bug 825583 comment 14, Brian says: "The other changes are good". r=me

(In reply to Cykesiopka from comment #0)
> I also want to change '0's to nsIX509CertDB.UNTRUSTED as appropriate, but
> I'm not sure now if that should be done.

I would wait on this - I think those sorts of things can be done when we do the certificate manager UI refresh.

Comment 3

[:Cykesiopka]

(In reply to David Keeler (:keeler) from comment #2)
> I would wait on this - I think those sorts of things can be done when we do
> the certificate manager UI refresh.

Ok, thanks.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b8e5d9152bcd

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b8e5d9152bcd