906973 - Firefox for Android redirect test is failing -- links to /includes/prefetch.php

Status: VERIFIED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Our redirect test(s) are failing:

self = <tests.test_redirect.TestRedirects object at 0x10aab4a50>
mozwebqa = <pytest_mozwebqa.pytest_mozwebqa.TestSetup instance at 0x10aa9e3b0>

@pytest.mark.nondestructive
def test_aurora_redirects_to_firefox_aurora(self, mozwebqa):
url = mozwebqa.base_url + "/aurora/"
response = requests.get(url)
result = mozwebqa.base_url + "/en-US/firefox/aurora/"
> Assert.equal(result, response.url)

tests/test_redirect.py:49:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <class unittestzero.Assert at 0x10aaf2120>
first = 'https://www-dev.allizom.org/en-US/firefox/aurora/'
second = u'https://www-dev.allizom.org/en-US/includes/prefetch.php/en-US/firefox/aurora/'
msg = None

@classmethod
def equal(self, first, second, msg=None):
"""
Asserts that 2 elements are the same

:Args:
- First object to be tested
- Second object to be tested
- Message that will be printed if it fails
"""
> assert first == second, msg
E assert 'https://www-...refox/aurora/' == u'https://www-...refox/aurora/'
E - https://www-dev.allizom.org/en-US/firefox/aurora/
E + https://www-dev.allizom.org/en-US/includes/prefetch.php/en-US/firefox/aurora/
E ? ++++++++++++++++++++++++++++

.env/lib/python2.7/site-packages/unittestzero.py:53: AssertionError

Comment 1

[Pascal Chevrel:pascalc]

This is happening to many localized pages as well, it seems that it happens for all pages that have an index.html file, ex:

Works:
https://www-dev.allizom.org/en-US/mobile/sms-thanks.html

Broken:
https://www-dev.allizom.org/en-US/mobile/1.0/releasenotes/

I couldn't find any change on dev-allizom on svn that could explain it (I even reverted my last commit to controller.inc.html just in case), I am wondering if this bedrock commit would not be the cause since it affects specifically index.html files:

https://github.com/mozilla/bedrock/commit/e96fb442f974f0c5188373b1ea2d6eb9c3d86673

Comment 2

[Paul [:pmac] McLanahan]

Fixed this by reverting the aforementioned commit in 721a5b27ee15267f76109286a47972762e5a1b37. We'll have to keep playing with the rewrite rules to see where the conflict is. It's very confusing since this was just a redirect, so it must be interacting with some proxy URL normally unseen.

In any case, this is fixed.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx, verified FIXED.