90712 - [IMM] Enter key shouldn't commit composing string of ChangJie for WinXP

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Frank Tang]

I can reproduce this on WinNT4J and USWinME w/ Global IME. Not sure about other
platform.
It happen to both ChiangJie and bopomofo (the default) Traditional Chinese IME 
way to reproduce it
1. launch netscape6 composer
2. change IME to tradtional Chinese - say chiang jie IME
3. type 'a', it should bring up the radical 'sun' in precompoes mode. 
4. hit enter. 
expect result :
commit the precomposed text
actual result:
the precomposed text will be hightlight in yellow. and the text before it in the
same line will be reversed. The uesr will feel very confused. The visual
feedback is wrong. No data lost but it will mislead the user.

Comment 1

[Roy Yokoyama]

accepting and setting the milestone to 0.9.3 to see if I can fix this in time.

Comment 2

[Roy Yokoyama]

Moving milestone to 0.9.4 

Comment 3

[Frank Tang]

This looks very bad. 
mark nsbranch but m0.9.5

Comment 4

[msanz]

nsbranch- since Frank moved it to 0.9.5

Comment 5

[Frank Tang]

p3 m0.9.7

Comment 6

[Yuying Long]

nsbeta1

Comment 7

[nhottanscp]

nsbeta1-
 visual effect only

Comment 8

[Roy Yokoyama]

push off 0.9.8 to 0.9.9

Comment 9

[Frank Tang]

also happen to simp chinese window. nomitate for nsbeta1 again

Comment 10

[Frank Tang]

nsbeta1- per triage meeting

Comment 11

[Roy Yokoyama]

bulk milestone change

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

On Win7, Enter key doesn't affect composition state (i.e., nothing happens). This is right behavior.

On WinXP, Enter key commits '日' and inserts an LF. But on the other applications, '日' isn't committed. So, this is a remaining issue. I cannot reproduce this bug when I type two or more characters.

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e387a59bd2d7

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Cancel composition when Enter key message isn't consumed by IME

Let's cancel composition when Enter key isn't consumed by IME. This is same behavior as IE6.

Comment 15

[Makoto Kato [:m_kato]]

(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #12)
> On Win7, Enter key doesn't affect composition state (i.e., nothing happens).
> This is right behavior.
> 
> On WinXP, Enter key commits '日' and inserts an LF. But on the other
> applications, '日' isn't committed. So, this is a remaining issue. I cannot
> reproduce this bug when I type two or more characters.

When I test my Windows XP with New ChangJie 2010, I cannot reproduce this like your say.  Even if hit [Enter] key, '日' isn't committed by the follow.

Step
1. Turn on New ChangJie 2010
2. Focus any input field
3. Type 'a' to input '日'.  Then candidate window shows '日'
4. Hit [Enter]

What IME do you use?

Comment 16

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: screenshot of the property dialog ChangJie on WinXP

It's displayed as just "ChangJie". I cannot see any menu to show its version. I added this from the input language service UI.

And I also reproduce this bug with other Chinese IMEs including simplified Chinese's. I guess that they use same code to handle key and show reading window and candidate window.

Comment 17

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ah, I see, you use *New* ChangJie, the IME having this problem is called just "ChangJie".

Comment 18

[Makoto Kato [:m_kato]]

(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #17)
> Ah, I see, you use *New* ChangJie, the IME having this problem is called
> just "ChangJie".

Where can I get it from?  As zh-tw default, it is Microsoft New Phonetic IME 2002a.

Comment 19

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Screenshot of intalling ChangJie on WinXP-Ja

Isn't this exiting on your dropdown list of the "add..." UI?

Comment 20

[Makoto Kato [:m_kato]]

(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #19)
> Created attachment 8650310 [details]
> Screenshot of intalling ChangJie on WinXP-Ja
> 
> Isn't this exiting on your dropdown list of the "add..." UI?

Oh, thanks.  I found it.

Comment 21

[Makoto Kato [:m_kato]]

Comment on attachment 8649851 [details] [diff] [review]
Cancel composition when Enter key message isn't consumed by IME

Review of attachment 8649851 [details] [diff] [review]:
-----------------------------------------------------------------

But if we found a regression, this should be backed out.

Microsoft already provides new IME for Changjie and this seems to be only on XP, and it doesn't occur if using it.

Comment 22

[Makoto Kato [:m_kato]]

And even if this is Microsoft application, the behavior is different when using wordpad (Richedit control).
But I think editbox has correct behavior.  It is as same as IE's behavior.

Comment 23

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

> But if we found a regression, this should be backed out.

Yeah, in such case, we should mark this as WONTFIX because it's difficult to list up all IMEs which has same trouble.

Comment 24

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/d0065cf362cfb972084141de6c36067d0b64b89e
changeset:  d0065cf362cfb972084141de6c36067d0b64b89e
user:       Masayuki Nakano <[e-mail]>
date:       Thu Aug 20 17:31:10 2015 +0900
description:
Bug 90712 Cancel composition when Enter key message isn't consumed by IME r=m_kato

Comment 25

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d0065cf362cf