907187 - Rewrite Baseline -> Ion OSR to not use the StackFrame layout

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Jan de Mooij [:jandem]]

We no longer OSR from the interpreter into Ion code, so creating a fake StackFrame is no longer necessary. It would be nice if we could just memcpy the BaselineFrame to the heap.

When we do this we can also remove all StackFrame::offsetOf* methods.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

This patch copies the BaselineFrame + locals/stack Values to the heap instead of creating a StackFrame. Formals and |this| are no longer copied: the Baseline and Ion frame have the same frame prefix so we can just read them directly.

7 files changed, 39 insertions(+), 199 deletions(-)

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 820996 [details] [diff] [review]
Patch

Review of attachment 820996 [details] [diff] [review]:
-----------------------------------------------------------------

Nice cleanup.

Comment 3

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20feee5f3866

Try: https://tbpl.mozilla.org/?tree=Try&rev=bd76ccef0545

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/20feee5f3866