907188 - [Fig] - Do something with footer on an empty state bookmarks pane

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: screenshot

Currently on empty state in the bookmarks pane there is a dividing line with nothing underneath. Perhaps a tip can be added for the pane or the dividing line can be removed.

See screenshot (annotated in red)

Comment 1

[Lucas Rocha (:lucasr)]

ibarlow, any input here?

Comment 2

[Ian Barlow (:ibarlow)]

I'm not sure what kind of tip we would provide here, since we already have the blank "add bookmark" things.

I would prefer to simply remove the divider line and only show it when the list fills up beyond what the thumbnails can show.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

1. Doesn't enable the dividers during startup (avoids a divider flashing until the list is ready).
2. Enables/disables dividers based on entries in the list.

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 794234 [details] [diff] [review]
Patch

Review of attachment 794234 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: mobile/android/base/home/BookmarksPage.java
@@ +410,5 @@
> +                    if (c == null || c.getCount() == 0) {
> +                        mList.setHeaderDividersEnabled(false);
> +                    } else {
> +                        mList.setHeaderDividersEnabled(true);
> +                    }

nit: I'd simplify this like:

// Only show header dividers if the list is not empty
mList.setHeaderDividersEnabled(c != null && c.getCount() > 0);

Comment 5

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/fx-team/rev/2671f9fb3fcc

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2671f9fb3fcc