Closed Bug 907192 Opened 6 years ago Closed 6 years ago

[FIG] The tab count and page url or title is not updated until exiting edit mode

Categories

(Firefox for Android :: Awesomescreen, defect, P1, major)

All
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 26
Tracking Status
fennec 26+ ---

People

(Reporter: AdrianT, Assigned: Margaret)

References

Details

Attachments

(1 file)

Asus Transformer TF101
Android 4.0.4
Figgy Fennec 2013-08-19

Steps to reproduce:
1) Load google.com
2) Tap on the url bar to enter edit mode
3) Open new tabs from bookmark content menus, from the app menu or from the tab drawer button
4) Change between the tabs

Expected results:
The tab count is changed with each new tab opened

Actual results:
Regardless of the way new tabs are opened or if the user switches tabs the tab count is not updated until the user goes back to the original tab and exits edit mode
Priority: -- → P1
tracking-fennec: --- → ?
Hardware: ARM → All
Assignee: nobody → margaret.leibovic
tracking-fennec: ? → 26+
I'm having a hard time trying to reproduce this. While in editing mode, I opened new tabs from the context menu, but I found the tab count changed when I exited editing mode.

It sounds like when this bug was filed you could somehow switch between tabs without exiting editing mode, but I don't think we can do that anymore. Is this bug still valid?
Still an issue on Nightly 26.0a1 2013-08-28 on tablets (Asus TF101 running Android 4.0.4). Please see the video capture: http://youtu.be/QfC-JmZDtZg
Ah, I was just testing on a phone, where we hide the tab count during editing mode. We'll need to fix this for tablets.
Attached patch patchSplinter Review
With this patch, we only suppress tab count updates in editing mode on phones, not on tablets.
Attachment #800391 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 800391 [details] [diff] [review]
patch

Review of attachment 800391 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: mobile/android/base/BrowserToolbar.java
@@ -861,5 @@
>              return;
>          }
>  
> -        // If toolbar is in edit mode, this means the entry is expanded and the
> -        // tabs button is translated offscreen. Don't trigger tabs counter

nit: add a period after counter :-)

@@ -875,5 @@
>      }
>  
>      public void updateTabCount(int count) {
> -        // If toolbar is in edit mode, this means the entry is expanded and the
> -        // tabs button is translated offscreen. Don't trigger tabs counter

nit: add a period after counter :-)

@@ +1381,3 @@
>  
>              if (!HardwareUtils.isTablet()) {
> +                updateTabCountAndAnimate(Tabs.getInstance().getDisplayCount());

I guess this is to avoid re-animating the tabs counter after leaving editing mode?
Attachment #800391 - Flags: review?(lucasr.at.mozilla) → review+
(In reply to Lucas Rocha (:lucasr) from comment #5)

> ::: mobile/android/base/BrowserToolbar.java
> @@ -861,5 @@
> >              return;
> >          }
> >  
> > -        // If toolbar is in edit mode, this means the entry is expanded and the
> > -        // tabs button is translated offscreen. Don't trigger tabs counter
> 
> nit: add a period after counter :-)

If you look at the next line, that's the middle of a sentence. I was just adjusting where the first line wrapped :)

> @@ +1381,3 @@
> >  
> >              if (!HardwareUtils.isTablet()) {
> > +                updateTabCountAndAnimate(Tabs.getInstance().getDisplayCount());
> 
> I guess this is to avoid re-animating the tabs counter after leaving editing
> mode?

Yes, that was my reasoning.
https://hg.mozilla.org/mozilla-central/rev/d12c27cb09ff
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.