907203 - Enable packaged apps for desktop

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect, P2)

Description

[Wil Clouser [:clouserw]]

Currently trying to enable a packaged app for desktop results in a message saying "Packaged apps are valid for only Firefox OS and Android."

Bill Walker says we're ready to turn on packaged apps for desktop, let's do it!

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Note: this feature landed in Firefox 25, which is currently in Aurora.  So it should be enabled just for that version and newer.  Also note that privileged apps don't work yet, although apps that use only privileges that apps get by default, like fullscreen and geolocation, will work.

Comment 2

[Andrew Williamson [:eviljeff]]

fyi - https://bugzilla.mozilla.org/show_bug.cgi?id=889744 - we still can't install reviewer packaged apps on Android yet...

Comment 3

[Matt Basta [:basta]]

(In reply to Myk Melez [:myk] [@mykmelez] from comment #1)
> Note: this feature landed in Firefox 25, which is currently in Aurora.  So
> it should be enabled just for that version and newer.  Also note that
> privileged apps don't work yet, although apps that use only privileges that
> apps get by default, like fullscreen and geolocation, will work.

We have no way to enable packaged apps on a per-version basis. We only, however, enable the Install button for packaged apps if the mozApps.installPackage API is present.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/5a4cca5
https://github.com/mozilla/fireplace/commit/669eefde

We should probably email all developers of Firefox OS+Android packaged apps and tell them that support for desktop has landed.

Comment 5

[Andrew Williamson [:eviljeff]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #4)
> https://github.com/mozilla/zamboni/commit/5a4cca5
> https://github.com/mozilla/fireplace/commit/669eefde
> 
> We should probably email all developers of Firefox OS+Android packaged apps
> and tell them that support for desktop has landed.

We should certainly not.  We don't know if we can test the things!

To be clear: we remove Android compatibility from packaged apps during the review as we can't review them.  If developers add support for Desktop to their packaged apps we will remove that also, until a time when we can review them.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/cfe5c8a

Comment 7

[Victor Carciu]

Verified as fixed . Packaged app on desktop : http://screencast.com/t/bkUm73RkR4o

Comment 8

[Christopher Van Wiemeersch [:cvan]]

Evidently, signed packaged apps cannot be installed on desktop yet (bug 908857) - and we sign all our apps.

Comment 9

[Christopher Van Wiemeersch [:cvan]]

Reverted: https://github.com/mozilla/zamboni/commit/b116f03

When bug 909458 is closed, revert this revert and packaged app submission will work as expected!

Comment 10

[Christopher Van Wiemeersch [:cvan]]

Removing out of this milestone until bug 909458 gets closed.

Comment 11

[Christopher Van Wiemeersch [:cvan]]

Going to start waffling per bug 908730 comment 5.

Comment 12

[Wil Clouser [:clouserw]]

We want this on -dev, not prod

Comment 13

[Andrew Williamson [:eviljeff]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #11)
> Going to start waffling per bug 908730 comment 5.

Is this waffle just for desktop support for packaged apps?

Comment 14

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/a5a9b3d

Packaged apps for desktop can now be toggled on -dev/stage/prod using the `desktop-packaged` waffle flag. https://marketplace-dev.allizom.org/admin/models/waffle/flag/24

Comment 15

[Andrew Williamson [:eviljeff]]

should be:
https://marketplace-dev.allizom.org/admin/models/waffle/flag/27/

Comment 16

[Victor Carciu]

Can you please add some specific STRs to this bug or mark it as [qa-] ?

Comment 17

[Christopher Van Wiemeersch [:cvan]]

(In reply to Victor Carciu from comment #16)
> Can you please add some specific STRs to this bug or mark it as [qa-] ?

As mentioned in comment 14, packaged apps can now be submitted on desktop if the waffle flag `desktop-packaged` is enabled.

Comment 18

[Victor Carciu]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #17)
> (In reply to Victor Carciu from comment #16)
> > Can you please add some specific STRs to this bug or mark it as [qa-] ?
> 
> As mentioned in comment 14, packaged apps can now be submitted on desktop if
> the waffle flag `desktop-packaged` is enabled.

Can you please enable this flag for me for testing purposes? I tried to enable it but I don't have the enough admin rights.

Comment 19

[Christopher Van Wiemeersch [:cvan]]

(In reply to Victor Carciu from comment #18)

> Can you please enable this flag for me for testing purposes? I tried to
> enable it but I don't have the enough admin rights.

Enabled. You should definitely have admin privileges on -dev.

Which user account are you testing with on -dev? (Which email?)