Enable packaged apps for desktop

RESOLVED FIXED in 2013-09-10

Status

Marketplace
General
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: clouserw, Assigned: cvan)

Tracking

2013-09-10
Points:
---
Dependency tree / graph

Details

(Whiteboard: [qa+])

(Reporter)

Description

5 years ago
Currently trying to enable a packaged app for desktop results in a message saying "Packaged apps are valid for only Firefox OS and Android."

Bill Walker says we're ready to turn on packaged apps for desktop, let's do it!
Note: this feature landed in Firefox 25, which is currently in Aurora.  So it should be enabled just for that version and newer.  Also note that privileged apps don't work yet, although apps that use only privileges that apps get by default, like fullscreen and geolocation, will work.
(Assignee)

Updated

5 years ago
Assignee: nobody → cvan
Target Milestone: --- → 2013-08-27
fyi - https://bugzilla.mozilla.org/show_bug.cgi?id=889744 - we still can't install reviewer packaged apps on Android yet...

Comment 3

5 years ago
(In reply to Myk Melez [:myk] [@mykmelez] from comment #1)
> Note: this feature landed in Firefox 25, which is currently in Aurora.  So
> it should be enabled just for that version and newer.  Also note that
> privileged apps don't work yet, although apps that use only privileges that
> apps get by default, like fullscreen and geolocation, will work.

We have no way to enable packaged apps on a per-version basis. We only, however, enable the Install button for packaged apps if the mozApps.installPackage API is present.
(Assignee)

Comment 4

5 years ago
https://github.com/mozilla/zamboni/commit/5a4cca5
https://github.com/mozilla/fireplace/commit/669eefde

We should probably email all developers of Firefox OS+Android packaged apps and tell them that support for desktop has landed.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Whiteboard: [qa+]
(In reply to Christopher Van Wiemeersch [:cvan] from comment #4)
> https://github.com/mozilla/zamboni/commit/5a4cca5
> https://github.com/mozilla/fireplace/commit/669eefde
> 
> We should probably email all developers of Firefox OS+Android packaged apps
> and tell them that support for desktop has landed.

We should certainly not.  We don't know if we can test the things!

To be clear: we remove Android compatibility from packaged apps during the review as we can't review them.  If developers add support for Desktop to their packaged apps we will remove that also, until a time when we can review them.
(Assignee)

Updated

5 years ago
Blocks: 908730

Comment 7

5 years ago
Verified as fixed . Packaged app on desktop : http://screencast.com/t/bkUm73RkR4o
Status: RESOLVED → VERIFIED
(Assignee)

Comment 8

5 years ago
Evidently, signed packaged apps cannot be installed on desktop yet (bug 908857) - and we sign all our apps.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Depends on: 909458
(Assignee)

Comment 9

5 years ago
Reverted: https://github.com/mozilla/zamboni/commit/b116f03

When bug 909458 is closed, revert this revert and packaged app submission will work as expected!
(Assignee)

Comment 10

5 years ago
Removing out of this milestone until bug 909458 gets closed.
Target Milestone: 2013-08-27 → ---
(Assignee)

Comment 11

5 years ago
Going to start waffling per bug 908730 comment 5.
Target Milestone: --- → 2013-09-03
(Reporter)

Updated

5 years ago
Priority: -- → P2
(Reporter)

Comment 12

5 years ago
We want this on -dev, not prod
(In reply to Christopher Van Wiemeersch [:cvan] from comment #11)
> Going to start waffling per bug 908730 comment 5.

Is this waffle just for desktop support for packaged apps?
(Assignee)

Comment 14

5 years ago
https://github.com/mozilla/zamboni/commit/a5a9b3d

Packaged apps for desktop can now be toggled on -dev/stage/prod using the `desktop-packaged` waffle flag. https://marketplace-dev.allizom.org/admin/models/waffle/flag/24
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Target Milestone: 2013-09-03 → 2013-09-10

Comment 16

5 years ago
Can you please add some specific STRs to this bug or mark it as [qa-] ?
Flags: needinfo?(cvan)
(Assignee)

Comment 17

5 years ago
(In reply to Victor Carciu from comment #16)
> Can you please add some specific STRs to this bug or mark it as [qa-] ?

As mentioned in comment 14, packaged apps can now be submitted on desktop if the waffle flag `desktop-packaged` is enabled.
Flags: needinfo?(cvan)

Comment 18

5 years ago
(In reply to Christopher Van Wiemeersch [:cvan] from comment #17)
> (In reply to Victor Carciu from comment #16)
> > Can you please add some specific STRs to this bug or mark it as [qa-] ?
> 
> As mentioned in comment 14, packaged apps can now be submitted on desktop if
> the waffle flag `desktop-packaged` is enabled.

Can you please enable this flag for me for testing purposes? I tried to enable it but I don't have the enough admin rights.
(Assignee)

Comment 19

5 years ago
(In reply to Victor Carciu from comment #18)

> Can you please enable this flag for me for testing purposes? I tried to
> enable it but I don't have the enough admin rights.

Enabled. You should definitely have admin privileges on -dev.

Which user account are you testing with on -dev? (Which email?)
You need to log in before you can comment on or make changes to this bug.