[MP] Defect - Opening a new tab when the page has focus doesn't correctly focus the location bar

VERIFIED FIXED in Firefox 26

Status

P2
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: cwiiis, Assigned: rsilveira)

Tracking

unspecified
Firefox 26
x86_64
Windows 8
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [preview] feature=defect c=tbd u=tbd p=1)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
If you browse to a page, click/touch in the page, then open a new tab with ctrl+t, the location bar appears to be focused, but does not actually hold focus (it's highlighted orange, but no cursor and typing doesn't work)

Updated

5 years ago
Blocks: 838081
Summary: Opening a new tab when the page has focus doesn't correctly focus the location bar → Defect - Opening a new tab when the page has focus doesn't correctly focus the location bar
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0

Updated

5 years ago
Blocks: 899390
Summary: Defect - Opening a new tab when the page has focus doesn't correctly focus the location bar → [MP] Defect - Opening a new tab when the page has focus doesn't correctly focus the location bar
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=0
Currently, the thing that gets highlighted is a xul box around the input, it's possible for that to get out of sync with the input. We need to look at making sure the editing state gets set and unset at all of the right times.

Alternately, we could just get rid of editing state and use CSS4 parent selectors (but I forget whether we implement those right now...).
Created attachment 795772 [details] [diff] [review]
patch v1

We're setting the focus while the navbar was not visible.
Assignee: nobody → rsilveira
Status: NEW → ASSIGNED
Hi Rodrigo, can you provide a point estimate for this defect.
Blocks: 904269
No longer blocks: 838081
Flags: needinfo?(rsilveira)
Priority: -- → P2
QA Contact: jbecerra
(Assignee)

Updated

5 years ago
Flags: needinfo?(rsilveira)
Whiteboard: [preview] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=1
Created attachment 796070 [details] [diff] [review]
Patch v2
Attachment #795772 - Attachment is obsolete: true
Attachment #796070 - Flags: review?(mbrubeck)
Comment on attachment 796070 [details] [diff] [review]
Patch v2

Could you add a test for this too (maybe in browser_contextui.js)?
Attachment #796070 - Flags: review?(mbrubeck) → review+
Created attachment 796190 [details] [diff] [review]
Test fix

Verified that it failed without the fix.
Attachment #796190 - Flags: review?(mbrubeck)
Attachment #796190 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/mozilla-central/rev/77e25cd0d80e
https://hg.mozilla.org/mozilla-central/rev/17e8229405fe
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Verified as fixed, with the latest Nightly (build ID: 20130915030208), for iteration #14, on Win 8 64bit, by following the STR from comment 0.

I think this also needs some device verification.
Status: RESOLVED → VERIFIED
Went through the following "Defect" for iteration #15 (touch device verification) without issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-10-15-03-03-19-mozilla-central/

- Went through the original defect described in comment #0 without any issues
- Ensured that the URL bar was selected with a cursor when using the CTRL + T method
- Ensured that the URL bar was selected with a cursor when using the "+" button in the "Tab App Bar"
- Ensured that the URL bar was selected with a cursor when using the junior style button
- Went through all of the above test cases in filled and full views without issues
You need to log in before you can comment on or make changes to this bug.