907244 - [MP] Defect - Opening a new tab when the page has focus doesn't correctly focus the location bar

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Input, defect, P2)

Description

[Chris Lord [:cwiiis]]

If you browse to a page, click/touch in the page, then open a new tab with ctrl+t, the location bar appears to be focused, but does not actually hold focus (it's highlighted orange, but no cursor and typing doesn't work)

Comment 1

[Jonathan Wilde [:jwilde]]

Currently, the thing that gets highlighted is a xul box around the input, it's possible for that to get out of sync with the input. We need to look at making sure the editing state gets set and unset at all of the right times.

Alternately, we could just get rid of editing state and use CSS4 parent selectors (but I forget whether we implement those right now...).

Comment 2

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: patch v1

We're setting the focus while the navbar was not visible.

Comment 3

[Marco Mucci [:MarcoM]]

Hi Rodrigo, can you provide a point estimate for this defect.

Comment 4

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v2

Comment 5

[Matt Brubeck (:mbrubeck)]

Comment on attachment 796070 [details] [diff] [review]
Patch v2

Could you add a test for this too (maybe in browser_contextui.js)?

Comment 6

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Test fix

Verified that it failed without the fix.

Comment 7

[Rodrigo Silveira [:rsilveira] [:rodms]]

Thanks!

https://hg.mozilla.org/integration/fx-team/rev/77e25cd0d80e
https://hg.mozilla.org/integration/fx-team/rev/17e8229405fe

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/77e25cd0d80e
https://hg.mozilla.org/mozilla-central/rev/17e8229405fe

Comment 9

[Manuela Muntean [Away]]

Verified as fixed, with the latest Nightly (build ID: 20130915030208), for iteration #14, on Win 8 64bit, by following the STR from comment 0.

I think this also needs some device verification.

Comment 10

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #15 (touch device verification) without issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-10-15-03-03-19-mozilla-central/

- Went through the original defect described in comment #0 without any issues
- Ensured that the URL bar was selected with a cursor when using the CTRL + T method
- Ensured that the URL bar was selected with a cursor when using the "+" button in the "Tab App Bar"
- Ensured that the URL bar was selected with a cursor when using the junior style button
- Went through all of the above test cases in filled and full views without issues