907309 - Avoid skipping frames in the image bridge

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Currently we only send the ImageContainer to the ImageBridge thread. This means that the active image can change before we get around to servicing it. This seems to be an unintentional change from the B2G 1.1 behaviour

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Pass the Image directly to the image bridge thread

Here's a working version of this. This combined with the patch to hold a reference to the Image while the compositor has it, seems to let us get back up to 24fps h.264 video. However, we seem to be just barely there so I suspect that there may be other problems yet.

Note: it currently manually addrefs and release which should probably be fixed.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Jeff, do we still need this?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

I'm not sure. Sotaro what do you think?

Comment 4

[Sotaro Ikeda [:sotaro]]

We do not need this. ImageBridge is only used for video and camera preview rendering. In android case, only most recent video/camera frame is rendered. older frames are just dropped.

If we are going to get an use case of not to skip video frame, we should implement it by extending ImageContainer. It is consistent with the MediaStreamGraph.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Based on comment 4