Closed Bug 907358 Opened 8 years ago Closed 8 years ago

Exactly root the internal pointers in Array.join

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla26

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file, 1 obsolete file)

exactly_root_array_join-v0.diff
1.94 KB, patch
Waldo
: review+
Details | Diff | Splinter Review
Attached patch exactly_root_array_join-v0.diff (obsolete) — — Splinter Review 
array_join_sub iterates the dense elements of arrays using Value*'s on the stack. These may be inline for arrays and the rooting analysis is correctly poisoning them. We could add 3 SkipRoots here, or just rephrase the loop in terms of |i|. I opted for the second, since it is a bit cleaner anyway, given the continuation loop.
Attachment #793029 - Flags: review?(jwalden+bmo)
This time with more qreffing.
Attachment #793029 - Attachment is obsolete: true
Attachment #793029 - Flags: review?(jwalden+bmo)
Attachment #793052 - Flags: review?(jwalden+bmo)
Attachment #793052 - Flags: review?(jwalden+bmo) → review+
Backed out in:

https://hg.mozilla.org/integration/mozilla-inbound/rev/c67d8048401e

While I investigate the bustage.
https://hg.mozilla.org/mozilla-central/rev/a1313bd99363
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.