907358 - Exactly root the internal pointers in Array.join

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: exactly_root_array_join-v0.diff

array_join_sub iterates the dense elements of arrays using Value*'s on the stack. These may be inline for arrays and the rooting analysis is correctly poisoning them. We could add 3 SkipRoots here, or just rephrase the loop in terms of |i|. I opted for the second, since it is a bit cleaner anyway, given the continuation loop.

Comment 1

[Terrence Cole [:terrence]]

Attachment: exactly_root_array_join-v0.diff

This time with more qreffing.

Comment 2

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0fc0283ac2b1

Comment 3

[Terrence Cole [:terrence]]

Backed out in:

https://hg.mozilla.org/integration/mozilla-inbound/rev/c67d8048401e

While I investigate the bustage.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/0fc0283ac2b1

Comment 5

[Terrence Cole [:terrence]]

Relanded:

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1313bd99363

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a1313bd99363