This also means we will need to make some tweaks to the editor system itself so plugin specific draggable/resizable/contenteditable/droppable can be setup with editors themselves.
Created attachment 829474 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/305 This is a lot and we should probably review it together in person. As a quick summary, this patch moves our EditorHelper code to be setup during editor loading. EditorHelper functionality is now specified along with an editor so now any plugin that desires this functionality requires an editor. This patch also moves jQuery, jQuery-UI and Farbtastic to be loaded via require as that was needed for this patch to work.
Attachment #829474 - Flags: review?(scott)
Comment on attachment 829474 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/305 One nit, and another comment.
Attachment #829474 - Flags: review?(scott) → review-
Comment on attachment 829474 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/305 Fixed up.
Attachment #829474 - Flags: review- → review?(scott)
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/1d0ee9265ebc09b7d930c1c4739bf4d5858b16c7 Fix Bug 907385 - Rewrite EditorHelper code into AMD module. Change jQuery loading to bower
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.