907385 - Make EditorHelper requirable via AMD

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Matthew Schranz [:mjschranz]]

This also means we will need to make some tweaks to the editor system itself so plugin specific draggable/resizable/contenteditable/droppable can be setup with editors themselves.

Comment 1

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/305

This is a lot and we should probably review it together in person.

As a quick summary, this patch moves our EditorHelper code to be setup during editor loading. EditorHelper functionality is now specified along with an editor so now any plugin that desires this functionality requires an editor. This patch also moves jQuery, jQuery-UI and Farbtastic to be loaded via require as that was needed for this patch to work.

Comment 2

[Scott [:thecount] Downe]

Comment on attachment 829474 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/305

One nit, and another comment.

Comment 3

[Matthew Schranz [:mjschranz]]

Comment on attachment 829474 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/305

Fixed up.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/1d0ee9265ebc09b7d930c1c4739bf4d5858b16c7
Fix Bug 907385 - Rewrite EditorHelper code into AMD module. Change jQuery loading to bower