Closed Bug 907404 Opened 7 years ago Closed 7 years ago

disable whatsnew for official branding

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 26
Tracking Status
firefox24 --- verified
firefox25 --- verified
firefox26 --- verified

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

Attachments

(1 file)

Currently, the official branding package displays a whatsnew page:

https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/whatsnew/?oldversion=%OLD_VERSION%

In practice, we disable that page for updates using the functionality from bug 538331 (see also bug 682805, attachment 569544 [details] [diff] [review]).

That leaves the page showing if users update manually, though. Since we've determine that we don't want to be showing this page on every update, we should disable the page in the product as well, so it's disabled consistently regardless of the update mechanism.
LGTM
Attached patch patchSplinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #793098 - Flags: review?(dolske)
This will mean we implement bug 892972 differently, but that's fine if this change makes it to Firefox 25.
Blocks: 892972
Attachment #793098 - Flags: review?(dolske) → review+
I like this, now we're just waiting on Asa.
Flags: needinfo?(asa)
See comment 1!
Flags: needinfo?(asa)
Comment on attachment 793098 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: useless whatsnew pages appear for manual updates
Testing completed (on m-c, etc.): none
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none
Attachment #793098 - Flags: approval-mozilla-beta?
Attachment #793098 - Flags: approval-mozilla-aurora?
Comment on attachment 793098 [details] [diff] [review]
patch

so few letters in that comment that I missed it :)
Attachment #793098 - Flags: approval-mozilla-beta?
Attachment #793098 - Flags: approval-mozilla-beta+
Attachment #793098 - Flags: approval-mozilla-aurora?
Attachment #793098 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/613a1db679dc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Keywords: checkin-needed
Whiteboard: [c-n for beta/aurora]
When will the whatsnew start to be disabled on all downloads/silent updates?
Keywords: verifyme
Verified as fixed on: Win 8 32bit, Mac 10.8.4 and Ubuntu 13.04 32bit.

Whatsnew page doesn't appear anymore when first opening Firefox 24 RC (as opposed to Firefox 23), in both of the next scenarios:

1) when making a simple installation of FF 24
2) when making a pave-over install of FF 24 over FF 23
QA Contact: manuela.muntean
(In reply to Chris More [:cmore] from comment #10)
> When will the whatsnew start to be disabled on all downloads/silent updates?

"silent" updates never got whatsnew, but the change in this bug (disable for non-updater triggered updates) will take effect in Firefox 24 (see status flags).
Verified as fixed on: Win 7 32bit, and Ubuntu 12.10 32bit.

Whatsnew page doesn't appear anymore when first opening Firefox 25 beta 1 (build ID: 20130917123208), in both of the next scenarios:

1) when making a simple installation of FF 25 beta 1
2) when making a pave-over install of FF 25 beta 1 over FF 24 beta 2
Mozilla/5.0 (X11; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:26.0) Gecko/20100101 Firefox/26.0

Verified as fixed on latest Aurora 26.0a2 (buildID: 20131003004003).
Status: RESOLVED → VERIFIED
Keywords: verifyme
See Also: → 1547830
You need to log in before you can comment on or make changes to this bug.