907404 - disable whatsnew for official branding

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Currently, the official branding package displays a whatsnew page:

https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/whatsnew/?oldversion=%OLD_VERSION%

In practice, we disable that page for updates using the functionality from bug 538331 (see also bug 682805, attachment 569544 [details] [diff] [review]).

That leaves the page showing if users update manually, though. Since we've determine that we don't want to be showing this page on every update, we should disable the page in the product as well, so it's disabled consistently regardless of the update mechanism.

Comment 1

[Asa Dotzler [:asa]]

LGTM

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

This will mean we implement bug 892972 differently, but that's fine if this change makes it to Firefox 25.

Comment 4

[Alex Keybl [:akeybl]]

I like this, now we're just waiting on Asa.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

See comment 1!

Comment 6

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/fx-team/rev/613a1db679dc

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 793098 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: useless whatsnew pages appear for manual updates
Testing completed (on m-c, etc.): none
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 793098 [details] [diff] [review]
patch

so few letters in that comment that I missed it :)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/613a1db679dc

Comment 10

[Chris More [:cmore]]

When will the whatsnew start to be disabled on all downloads/silent updates?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d3736955cf31
https://hg.mozilla.org/releases/mozilla-beta/rev/ba0b21a948d5

Comment 12

[Manuela Muntean [Away]]

Verified as fixed on: Win 8 32bit, Mac 10.8.4 and Ubuntu 13.04 32bit.

Whatsnew page doesn't appear anymore when first opening Firefox 24 RC (as opposed to Firefox 23), in both of the next scenarios:

1) when making a simple installation of FF 24
2) when making a pave-over install of FF 24 over FF 23

Comment 13

[:Gavin Sharp [email: [e-mail]]]

(In reply to Chris More [:cmore] from comment #10)
> When will the whatsnew start to be disabled on all downloads/silent updates?

"silent" updates never got whatsnew, but the change in this bug (disable for non-updater triggered updates) will take effect in Firefox 24 (see status flags).

Comment 14

[Manuela Muntean [Away]]

Verified as fixed on: Win 7 32bit, and Ubuntu 12.10 32bit.

Whatsnew page doesn't appear anymore when first opening Firefox 25 beta 1 (build ID: 20130917123208), in both of the next scenarios:

1) when making a simple installation of FF 25 beta 1
2) when making a pave-over install of FF 25 beta 1 over FF 24 beta 2

Comment 15

[Bogdan Maris, Desktop Test Engineering]

Mozilla/5.0 (X11; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:26.0) Gecko/20100101 Firefox/26.0

Verified as fixed on latest Aurora 26.0a2 (buildID: 20131003004003).