907443 - [B2G] [Buri] [1.2] [Dialer] Keypad is unresponsive during phone call

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Chris Kreinbring [:CKreinbring]]

Attachment: Log of call and keypad tap attempt

Description:
After beginning a call, the keypad is unresponsive for the duration of the call.

Repro Steps:
1) Update Buri to Build ID: 20130820040204
2) Launch the dialer and make a call to a number that will require keypad entry.
3) Once call connection is established, tap the keypad button in the middle to call up the keypad.
4) At an appropriate prompt, tap a number on the keypad and observe the reaction.

Actual:
There is no response when the keypad buttons are tapped.

Expected:
When a keypad button is tapped, the number tapped is shown on the phone number bar and an appropriate response from the called location should be triggered.

Environmental Variables
Occurs on Buri 1.2 mozilla RIL
Build ID: 20130820040204
Gecko: http://hg.mozilla.org/mozilla-central/rev/bb025b6949e8
Gaia: 7249b5d61b955c23efe9e18f80f0da2e78d827eb
Platform Version: 26.0a1

Notes:
Repro frequency: 100%
See attached logcat logs

Comment 1

[Natalya Kot [:nkot]]

regression range:

Build ID: 20130813040222 - does NOT reproduce
Gecko: http://hg.mozilla.org/mozilla-central/rev/8c240c67f76c
Gaia: b527d7406b4eed3bacdee78597bb4ff21bf9f7d0
Platform Version: 26.0a1

Build ID: 20130814040203 - Reproduces
Gecko: http://hg.mozilla.org/mozilla-central/rev/3c61cc01a3b1
Gaia: 9e0f6e30e5e28f88b4bbb4acb5e1fc99cdf7b7e7
Platform Version: 26.0a1

*Buri: US_20130808

Comment 2

[Preeti Raghunath(:Preeti)]

David,

Please help reassign, as this is a regression issue on 1.2.

Comment 3

[Hubert Lu[:hlu] <[e-mail]>]

This issue happens in Nexus 4 v1.2 with Android 4.3, the test environment is as below.

[Version Info]
Gaia:     14f47e5390f6fb9b0c4c841f34024870b7052cfb
  B-D     2013-08-23 14:27:51
Gecko:    e4a2844f7941ce2c797fccdfdb03761f1f333a6a
BuildID   20130823142744
Version   26.0a1
Kernel    4.3

Comment 4

[Anthony Ricaud (:rik)]

Rex: You told us that you had spare cycles. Can you look at this? With the regression window, if it's a Gaia bug, I think this is a regression of bug 902983.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

OK, it's reproducible for me. I'll take a look.

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Yes it's a regression of bug 902983.
We need to make CallsHandler.activeCall a properties just like before. patch:
https://github.com/rexboy7/gaia/commit/62891c7d610ca550da8f15e4a7a091c67db38eb1

I'll try if I can write some unit test for activeCall before sending review.

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

Done. It's a simple patch.

Anthony may you help review it?

Comment 8

[Anthony Ricaud (:rik)]

Comment on attachment 797105 [details]
patch

r+ with a small change.

Thanks!

Comment 9

[Jason Smith [:jsmith]]

Rex - Can you land this so that we can unblock a smoketest?

Comment 10

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Sure!

master:
https://github.com/mozilla-b2g/gaia/commit/fba4ad20f75c4f16b14521a5de6b72c4d6356c1f

Comment 11

[J Zimbrick]

Issue no longer appears to be occurring on a Buri device running the latest 1.2 moz build:

Build ID: 20130830040204
Gecko: http://hg.mozilla.org/mozilla-central/rev/c7459bc8e449
Gaia: 407fbfb6a9de68ec4db2f0f3dc6c67463e293f47
Platform Version: 26.0a1
RIL Version: 01.01.00.019.205
Base Image Date: 20130823

Touchtones are registering correctly while making a call. I was able to connect to the mozilla conference line without issue.

Verifying as fixed.