907473 - WebRTC misconfigures on Android somehow, builds cpu_info as though it were Linux rather than Android

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Phil Ringnalda (:philor)]

Second time we've seen this: https://tbpl.mozilla.org/php/getParsedLog.php?id=26786385&tree=Mozilla-Inbound is an Android build trying to find get_nprocs, which it should only be doing for Linux && !Android, but it died with

../../../../../../../../media/webrtc/trunk/webrtc/system_wrappers/source/cpu_info.cc: In static member function 'static uint32_t webrtc::CpuInfo::DetectNumberOfCores()':
../../../../../../../../media/webrtc/trunk/webrtc/system_wrappers/source/cpu_info.cc:43:35: error: 'get_nprocs' was not declared in this scope

despite the previous build being perfectly happy. glandium has a theory, which is good since I only have a bafflement.

Comment 1

[Mike Hommey [:glandium]]

Previous Android Armv6 build on the same slave:
https://tbpl.mozilla.org/php/getParsedLog.php?id=26770736&tree=Mozilla-Inbound

That previous build was a clobber. It thus ran configure.
The build corresponding to the log in comment 0 is an incremental build with webrtc changes in it. It didn't run configure, but ran gyp_chromium from the rule in the generated media/webrtc/trunk/common.mk. The problem is that gyp_chromium is not called with the -G os=android argument in that case.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Handle generator_flags gracefully in gyp

This is the easy fix.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 793213 [details] [diff] [review]
Handle generator_flags gracefully in gyp

Review of attachment 793213 [details] [diff] [review]:
-----------------------------------------------------------------

What could possibly go wrong?

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d271df63cff

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2d271df63cff

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 793213 [details] [diff] [review]
Handle generator_flags gracefully in gyp

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A

User impact if declined: Possibility of mysterious clobber-needing failures in automation as we've seen

Testing completed (on m-c, etc.): On m-c

Risk to taking this patch (and alternatives if risky): close to nil, and any failures would be to incremental builds

String or IDL/UUID changes made by this patch: none

Comment 7

[bhavana bajaj [:bajaj]]

Comment on attachment 793213 [details] [diff] [review]
Handle generator_flags gracefully in gyp

Approving, :glandium can you please make sure the aurora/beta builds are generated smoothly given the risk that is called out.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d6fa49bcf953
https://hg.mozilla.org/releases/mozilla-beta/rev/558ce0ef3f08