907497 - "mach resource-usage" fails on OS X

Status: NEW

(Firefox Build System :: General, defect)

Description

[Cameron McCormack (:heycam)]

When I run "./mach resource-usage" I get this:

  $ ./mach resource-usage
  70:78: execution error: File firefox wasn’t found. (-43)

If I run it with "--browser firefox" I don't get the error, but it also doesn't open up the browser.  "--browser safari" does manage to open Safari.

Comment 1

[Gregory Szorc [:gps]]

Did it not print the "'Please open <url> in a browser" message?

This is most weird. We're catching all exceptions in the Python code to open the web browser. If this error is coming from Python and isn't an exception, that seems like a bug in the Python standard library!

Search for "resource_usage" in python/mozbuild/mozbuild/mach_commands.py and try changing the default value for the "browser" argument to None (not a string - just the keyword None).

Comment 2

[Cameron McCormack (:heycam)]

(In reply to Gregory Szorc [:gps] from comment #1)
> Did it not print the "'Please open <url> in a browser" message?

No, though it still did say "Hit CTRL+c to stop server.".

> This is most weird. We're catching all exceptions in the Python code to open
> the web browser. If this error is coming from Python and isn't an exception,
> that seems like a bug in the Python standard library!
> 
> Search for "resource_usage" in python/mozbuild/mozbuild/mach_commands.py and
> try changing the default value for the "browser" argument to None (not a
> string - just the keyword None).

For the @CommandArgument?  (Since the actual function argument to resource_usage is already None.)

That worked, and opened a new tab in my already running Firefox.

Comment 3

[Corey Ford [:coyotebush]]

(In reply to Gregory Szorc [:gps] from comment #1)
> Search for "resource_usage" in python/mozbuild/mozbuild/mach_commands.py and
> try changing the default value for the "browser" argument to None (not a
> string - just the keyword None).

I was about to post a patch to do just that, on the reasoning that the webbrowser module can probably do a better job of picking a browser.

(Since I have both Beta and Nightly installed, but run Nightly, the current code makes Beta launch (but stop at the profile-in-use error) at the same time Nightly loads the page...)

Comment 4

[Garvit Khatri [:garvitdelhi]]

I was also going through the installation from the source on mac and wanted to use resource-usage. I also got the same error.

I pointed the python to my custom installation of Python from Source and found that on mac os webbrowser.get(browser) will never throw an exception, even if the browser is not found.

While webbrowser.get(browser).open_new_tab(server.url) returns False when it fails to open the tab. I have fixed this locally and will be sending a patch for the same.

Comment 5

[Garvit Khatri [:garvitdelhi]]

Attachment: Launch default browser if firefox is not found for resource-usage command

Comment 6

[Garvit Khatri [:garvitdelhi]]

Attachment: Launch default browser if firefox is not found for resource-usage command

Comment 7

[Garvit Khatri [:garvitdelhi]]

Attachment: Launch default browser if firefox is not found for resource-usage command