Closed Bug 907520 Opened 9 years ago Closed 9 years ago

[MP] Defect - OSK being left behind if you close "Find in page" app bar

Categories

(Firefox for Metro Graveyard :: Input, defect, P2)

x86_64
Windows 8.1
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: kjozwiak, Assigned: emtwo)

References

Details

(Whiteboard: [preview] feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=3)

Attachments

(2 files)

Attached image OSK being left behind
When you have the OSK & the "Find in page" opened at the same time, tapping on the close button "X" will dismiss the "Find in page" app bar but leave the OSK behind. Once the OSK is left behind, you can keep scrolling through the websites with the OSK visible the entire time.

- Attached a screenshot to illustrate the issue (OSK being left behind)

Steps to reproduce the issue:

1) Open Firefox Metro
2) Go to wikipedia.org
3) Once the website has loaded, swipe in the navigation app bar and select the "Settings" and then "Find in page"
4) The "Find in page" app bar should slide in, tap on the "search" field and the OSK should appear from the bottom
5) Tap on the "X" and dismiss the "Find in page" app bar, you'll notice that the OSK is left behind and you can scroll through the website with the OSK visible

Current Behavior:

- OSK being left behind when dismissing the "Find in page" app bar

Expected Behavior:

- OSK should be dismissed at the same time the "Find in page" is closed

Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-20-03-02-06-mozilla-central/
Whiteboard: feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=0 → [preview-triage] feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=0
Assignee: nobody → msamuel
Hi Marina, can you provide a point estimate for this defect.
Blocks: metrov1it13
No longer blocks: metrov1backlog
Status: NEW → ASSIGNED
Flags: needinfo?(msamuel)
Priority: -- → P2
QA Contact: jbecerra
Summary: Defect - OSK being left behind if you close "Find in page" app bar → [MP] Defect - OSK being left behind if you close "Find in page" app bar
Whiteboard: [preview-triage] feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=0 → [preview] feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=0
p=3
Flags: needinfo?(msamuel)
Whiteboard: [preview] feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=0 → [preview] feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=3
I suspected that calling blur() on 'transitionend' may not be working correctly so moved the blur() call outside which seems to have the effect we want.

I wanted to add a test but seems like it's hard to programmatically test for the visibility of the soft keyboard. Suggestions welcome.
Attachment #794643 - Flags: review?(mbrubeck)
Comment on attachment 794643 [details] [diff] [review]
v1: Close soft keyboard when findbar closes

Review of attachment 794643 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #794643 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/integration/fx-team/rev/39301b836507
Whiteboard: [preview] feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=3 → [fixed-in-fx-team][preview] feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=3
https://hg.mozilla.org/mozilla-central/rev/39301b836507
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][preview] feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=3 → [preview] feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=3
Target Milestone: --- → Firefox 26
Went through the following "Defect" for iteration #13 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-27-03-02-01-mozilla-central/

- Went through the original test case from comment #0 without any issues
- Ensured that pressing the "X" while the OSK is not visible will dismiss the "Find in page" app bar without any issues
- Ensured that while the OSK is visible, tapping on the screen will dismiss the OSK but still keep the "Find in page" bar visible at the bottom (also ensured that tapping on the search field would slide the OSK back into view)
- Ensured that tapping on the search field will slide in the OSK without any issues (also ensured the position was correct)
- Ensured that while the OSK & the "Find in page" app bar are visible, pressing "X" will dismiss both without any issues
- Ensured that all the transitions are smooth and not "laggy" or "slow"
- Ensured that when pressing the "New Tab" floating button on the right side of the screen while the "Find in page" app bar is visible openes a new tab and correctly dismisses the "Find in page" bar
- Went through all of the above test cases in filled view without any issues
Depends on: 917159
Went through the following "Defect" for iteration #14 and found an issue. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-09-15-03-02-08-mozilla-central/

- Found a defect when going through this defect, created a defect and attached it into this ticket.
Went through the following defect for iteration #20 without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-12-22-03-02-04-mozilla-central/

- Went through the original test case added in comment #0 without any issues
- Went through the test cases added in comment #7 without any issues
- Ensured that all of the above test cases also worked while in filled view
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.