907650 - "/builds/slave/b2g_m-in_emulator_dep-00000000/build/gecko/configure: line 9663: MOZ_DEBUGGING_OPTS: command not found" logspam in green runs

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ed Morley [:emorley]]

b2g_mozilla-inbound_emulator_dep on 2013-08-20 23:56:04 PDT for push 3faa29e53ac0

slave: bld-linux64-ec2-301

https://tbpl.mozilla.org/php/getParsedLog.php?id=26807802&tree=Mozilla-Inbound

{
00:36:00     INFO -  checking if toolchain supports -mssse3 option... no
00:36:00     INFO -  checking if toolchain supports -msse4.1 option... no
00:36:00     INFO -  checking whether the C compiler supports -Werror=return-type... yes
00:36:00     INFO -  checking whether the C compiler supports -Wtype-limits... yes
00:36:00     INFO -  checking whether the C compiler supports -Wempty-body... yes
00:36:00     INFO -  checking whether the C compiler supports -Wsign-compare... yes
00:36:00     INFO -  checking whether the C++ compiler supports -Werror=return-type... yes
00:36:00     INFO -  checking whether the C++ compiler supports -Wtype-limits... yes
00:36:00     INFO -  checking whether the C++ compiler supports -Wempty-body... yes
00:36:00     INFO -  checking whether the C++ compiler supports -Wsign-compare... yes
00:36:00     INFO -  checking whether the C++ compiler supports -Wno-invalid-offsetof... yes
00:36:00     INFO -  checking whether ld has archive extraction flags... no
00:36:00     INFO -  checking for 64-bit OS... no
00:36:00    ERROR -  /builds/slave/b2g_m-in_emulator_dep-00000000/build/gecko/configure: line 9663: MOZ_DEBUGGING_OPTS: command not found
}

then much later:
{
00:44:19     INFO -  In file included from ../../dist/include/nscore.h:14,
00:44:19     INFO -                   from ../../dist/include/nsrootidl.h:13,
00:44:19     INFO -                   from ../../dist/include/nsISupports.h:10,
00:44:19     INFO -                   from ../../dist/include/nsIObserver.h:10,
00:44:19     INFO -                   from ../../../gecko/xpcom/threads/LazyIdleThread.h:14,
00:44:19     INFO -                   from ../../../gecko/xpcom/threads/LazyIdleThread.cpp:7:
00:44:19  WARNING -  ../../dist/include/xpcom-config.h:38:1: warning: "NS_ATTR_MALLOC" redefined
00:44:19     INFO -  In file included from <command-line>:0:
00:44:19  WARNING -  ./../../mozilla-config.h:166:1: warning: this is the location of the previous definition
00:44:19     INFO -  In file included from ../../dist/include/nscore.h:20,
00:44:19     INFO -                   from ../../dist/include/nsrootidl.h:14,
00:44:19     INFO -                   from ../../dist/include/nsISupports.h:11,
00:44:19     INFO -                   from ../../dist/include/nsIObserver.h:11,
00:44:19     INFO -                   from ../../../gecko/xpcom/threads/LazyIdleThread.h:15,
00:44:19     INFO -                   from ../../../gecko/xpcom/threads/LazyIdleThread.cpp:8:
00:44:19    ERROR -  ../../dist/include/mozilla/mozalloc.h:81: error: expected initializer before '==' token
00:44:19    ERROR -  ../../dist/include/mozilla/mozalloc.h:85: error: expected initializer before '==' token
00:44:19    ERROR -  ../../dist/include/mozilla/mozalloc.h:89: error: expected initializer before '==' token
00:44:19    ERROR -  ../../dist/include/mozilla/mozalloc.h:92: error: expected initializer before '==' token
00:44:19    ERROR -  ../../dist/include/mozilla/mozalloc.h:96: error: expected initializer before '==' token
00:44:19    ERROR -  ../../dist/include/mozilla/mozalloc.h:99: error: expected initializer before '==' token
00:44:19    ERROR -  ../../dist/include/mozilla/mozalloc.h:103: error: expected initializer before '==' token
00:44:19    ERROR -  ../../dist/include/mozilla/mozalloc.h:106: error: expected initializer before '==' token
00:44:19    ERROR -  ../../dist/include/mozilla/mozalloc.h:114: error: expected initializer before '==' token
00:44:19    ERROR -  ../../dist/include/mozilla/mozalloc.h:117: error: expected initializer before '==' token
00:44:19     INFO -  In file included from ../../dist/include/nscore.h:20,
00:44:19     INFO -                   from ../../dist/include/nsrootidl.h:14,
00:44:19     INFO -                   from ../../dist/include/nsISupports.h:11,
00:44:19     INFO -                   from ../../dist/include/nsIObserver.h:11,
00:44:19     INFO -                   from ../../../gecko/xpcom/threads/LazyIdleThread.h:15,
00:44:19     INFO -                   from ../../../gecko/xpcom/threads/LazyIdleThread.cpp:8:
00:44:19    ERROR -  ../../dist/include/mozilla/mozalloc.h:132: error: expected initializer before '==' token
00:44:19    ERROR -  ../../dist/include/mozilla/mozalloc.h:135: error: expected initializer before '==' token
00:44:19    ERROR -  ../../dist/include/mozilla/mozalloc.h:141: error: expected initializer before '==' token
00:44:19    ERROR -  ../../dist/include/mozilla/mozalloc.h:144: error: expected initializer before '==' token
...
...
}

Comment 1

[Ed Morley [:emorley]]

(The line numbers will vary, so might end up being a manual star some of the time)

Comment 2

[Ryan VanderMeulen [:RyanVM]]

I've seen these errors in other logs, but I'm not sure that MOZ_DEBUGGING_OPTS isn't a red herring here. I'll point out that green runs have the same error :)

Comment 3

[Mike Hommey [:glandium]]

Yeah, it's a red herring, although it's noise that could go away. It's a patch folding error I did.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Mike, can you please fix this? It's an annoying source of logspam.

Comment 5

[Ed Morley [:emorley]]

This would have been picked up (if it occurred) prior to bug 892958.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Move debugging options configure.in goop in compiler-opts.m4

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 796993 [details] [diff] [review]
Move debugging options configure.in goop in compiler-opts.m4

Review of attachment 796993 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming this is copy paste, r+.

I was initially confused why you were creating MOZ_DEBUGGING_OPTS but didn't add a reference to the new macro anywhere. I was surprised to learn it already exists in compiler-opts.m4!

Comment 8

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bcf2e457c1e1

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bcf2e457c1e1