Open Bug 907761 Opened 7 years ago Updated 3 years ago

Port MOCSRCS to moz.build correctly

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: mshal, Unassigned)

Details

While doing the CPP_SOURCES conversion, I accidentally folded MOCSRCS into CPP_SOURCES. These would show up in Makefiles like so:

MOCSRCS = \
               moc_moziqwidget.cpp \
               moc_mozqwidget.cpp \
               moc_nsAppShell.cpp \
               $(NULL)

CPPSRCS += $(MOCSRCS) \
...

I thought this was just a local variable, but it is actually used by rules.mk to list the MOCSRCS as GARBAGE, since moc_*.cpp are generated by rules.mk:

moc_%.cpp: %.h
        $(REPORT_BUILD)
        $(ELOG) $(MOC) $(DEFINES) $(ACDEFINES) $< $(OUTOPTION)$@

I think we will need to convert these CPP_SOURCES in moz.build back to a separate MOC_SOURCES variable. The MOC_SOURCES should be automatically added to CPP_SOURCES by mozbuild, and added to GARBAGE (this could also be done by mozbuild in backend.mk rather than in rules.mk).
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.