Closed
Bug 907837
Opened 11 years ago
Closed 11 years ago
ImageContainer.h:11:10: fatal error: GeckoProfilerFunc.h' file not found (non-SPS)
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: jbeich, Assigned: jbeich)
References
()
Details
Attachments
(2 files)
9.41 KB,
patch
|
nrc
:
review+
|
Details | Diff | Splinter Review |
10.31 KB,
patch
|
nrc
:
review+
|
Details | Diff | Splinter Review |
On platforms without SPS profiler the build is broken due to GeckoProfilerFunc.h not being exported. gfx/gl/GLContext.cpp:14: In file included from dist/include/gfxUtils.h:12: dist/include/ImageContainer.h:11:10: fatal error: GeckoProfilerFunc.h' file not found #include "GeckoProfilerFunc.h" // for TimeStamp ^
TimeStamp and TimeDuration are in mozilla/TimeStamp.h while *_sampler_* functions defined in GeckoProfilerFunc.h are unused in those files.
Attachment #793587 -
Flags: review?(ncameron)
Attachment #793593 -
Flags: review?(ncameron)
Updated•11 years ago
|
Attachment #793587 -
Flags: review?(ncameron) → review+
Updated•11 years ago
|
Attachment #793593 -
Flags: review?(ncameron) → review+
Comment 4•11 years ago
|
||
I'm puzzled because i dont see that failure, and we dont have the SPS profiler on OpenBSD..
Comment 5•11 years ago
|
||
Thanks nick!
Keywords: checkin-needed
Comment 6•11 years ago
|
||
And now i know why i didnt see that failure... since 903816/Include-what-you-use landed, the two patches dont apply anymore, and are not needed ? Removing checkin-needed until someone sorts this out....
Keywords: checkin-needed
Comment 7•11 years ago
|
||
(In reply to Landry Breuil (:gaston) from comment #6) > And now i know why i didnt see that failure... since > 903816/Include-what-you-use landed, the two patches dont apply anymore, and > are not needed ? Removing checkin-needed until someone sorts this out.... I think the problem is caused by 903816 and these patches fix it. They should apply now.
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ed38ca05fd2 https://hg.mozilla.org/integration/mozilla-inbound/rev/806a989ec3ad
Assignee: nobody → jbeich
OS: FreeBSD → All
Hardware: x86_64 → All
Comment 9•11 years ago
|
||
Ok, disregard my remark then. I tried applying/pushing those two commits this morning, and failed. Maybe a local thing with my m-i clone. And i finally saw the same failure on some of my builders....
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2ed38ca05fd2 https://hg.mozilla.org/mozilla-central/rev/806a989ec3ad
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•