On platforms without SPS profiler the build is broken due to GeckoProfilerFunc.h not being exported. gfx/gl/GLContext.cpp:14: In file included from dist/include/gfxUtils.h:12: dist/include/ImageContainer.h:11:10: fatal error: GeckoProfilerFunc.h' file not found #include "GeckoProfilerFunc.h" // for TimeStamp ^
Created attachment 793587 [details] [diff] [review] remove bogus include TimeStamp and TimeDuration are in mozilla/TimeStamp.h while *_sampler_* functions defined in GeckoProfilerFunc.h are unused in those files.
Attachment #793587 - Flags: review?(ncameron)
Created attachment 793593 [details] [diff] [review] use stable header
Attachment #793593 - Flags: review?(ncameron)
I'm puzzled because i dont see that failure, and we dont have the SPS profiler on OpenBSD..
And now i know why i didnt see that failure... since 903816/Include-what-you-use landed, the two patches dont apply anymore, and are not needed ? Removing checkin-needed until someone sorts this out....
(In reply to Landry Breuil (:gaston) from comment #6) > And now i know why i didnt see that failure... since > 903816/Include-what-you-use landed, the two patches dont apply anymore, and > are not needed ? Removing checkin-needed until someone sorts this out.... I think the problem is caused by 903816 and these patches fix it. They should apply now.
Assignee: nobody → jbeich
OS: FreeBSD → All
Hardware: x86_64 → All
Ok, disregard my remark then. I tried applying/pushing those two commits this morning, and failed. Maybe a local thing with my m-i clone. And i finally saw the same failure on some of my builders....
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.