907868 - Do not hijack non-commbadge URLs from commbadge

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[Christopher Van Wiemeersch [:cvan]]

1. Load https://marketplace-dev.allizom.org/comm/
2. Click the app name for a particular thread - http://cl.ly/image/1x1X0O062O08/Screen%20Shot%202013-08-21%20at%2011.53.01%20AM.png
3. Notice that commbadge tries to find a view for the URL route /app/marketplace/ where in reality the view for that URL lives in Fireplace.

If the URL doesn't start with /comm/ we should assume it's an outbound link to Fireplace/Zamboni.

Comment 1

[Matt Basta [:basta]]

This is a change that I've speculated about in Fireplace. If you click a link that doesn't resolve to a view, navigation.js should treat it as an external link. This is a change we should make in commonplace.

Comment 3

[Matt Basta [:basta]]

Ashish landed the code for this in commonplace:

https://github.com/mozilla/commonplace/commit/9423c38b717ee033a18187488b87fb081a67b78d

Comment 4

[Matt Basta [:basta]]

Also landed in commbadge:

https://github.com/mozilla/commbadge/commit/669a8d36ad3e8905701ed63aebc2b6445801e2e6

Should be fixed!

Comment 5

[Christopher Van Wiemeersch [:cvan]]

Thanks!

Comment 6

[Victor Carciu]

Verified as fixed : http://screencast.com/t/LdiD9NmiYJD3