907879 - Hide content specific menu items for hardware menu access for an associated URL while in about:home

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently on devices with a hardware menu button one can access content specific menu items: share, save as PDF, find in page, request desktop site while in about:home (the user and URL is still on a website). Should these be disabled while the user is viewing about:home?

Comment 1

[Aaron Train [:aaronmt]]

Attachment: screenshot

Screenshot, you can access Find in Page for example in editing mode but that won't do anything for you

Comment 2

[Sriram Ramasubramanian [:sriram]]

I guess, for parity reasons with s/w menu, it's better to hide the menu when in editing mode. But in tablets we show this menu.

Comment 3

[Lucas Rocha (:lucasr)]

Yeah, disabling the hw menu options while in editing mode is probably the right thing to do here.

Comment 4

[Aaron Train [:aaronmt]]

Ian, long time needinfo^

Comment 5

[Ian Barlow (:ibarlow)]

(In reply to Aaron Train [:aaronmt] from comment #0)
> Currently on devices with a hardware menu button one can access content
> specific menu items: share, save as PDF, find in page, request desktop site
> while in about:home (the user and URL is still on a website). Should these
> be disabled while the user is viewing about:home?

Yes. :)

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.