Closed
Bug 907883
Opened 11 years ago
Closed 11 years ago
Minimize #includes in layout/generic
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
78.15 KB,
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=10d2330a31f2
Attachment #793633 -
Flags: review?(roc)
Assignee | ||
Comment 2•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=ca9d08dce565
Comment 3•11 years ago
|
||
Comment on attachment 793633 [details] [diff] [review] Patch (v1) > layout/base/nsPresContext.cpp +#include "nsObjectFrame.h" nsObjectFrame.h is already included (~17 lines above). Looks good otherwise. r=mats for the version that compiles ;-) Nice!
Attachment #793633 -
Flags: review?(roc) → review+
Assignee | ||
Comment 4•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=fd2c014211df
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Mats Palmgren (:mats) from comment #3) > Comment on attachment 793633 [details] [diff] [review] > Patch (v1) > > > layout/base/nsPresContext.cpp > +#include "nsObjectFrame.h" > > nsObjectFrame.h is already included (~17 lines above). Oops you're right! No idea why I did that. :-)
Assignee | ||
Comment 6•11 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/f10d31a0f7b4
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f10d31a0f7b4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•