Closed
Bug 907883
Opened 13 years ago
Closed 13 years ago
Minimize #includes in layout/generic
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
78.15 KB,
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #793633 -
Flags: review?(roc)
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
||
Comment 3•13 years ago
|
||
Comment on attachment 793633 [details] [diff] [review]
Patch (v1)
> layout/base/nsPresContext.cpp
+#include "nsObjectFrame.h"
nsObjectFrame.h is already included (~17 lines above).
Looks good otherwise. r=mats for the version that compiles ;-)
Nice!
Attachment #793633 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
|
Assignee | |
Comment 5•13 years ago
|
||
(In reply to Mats Palmgren (:mats) from comment #3)
> Comment on attachment 793633 [details] [diff] [review]
> Patch (v1)
>
> > layout/base/nsPresContext.cpp
> +#include "nsObjectFrame.h"
>
> nsObjectFrame.h is already included (~17 lines above).
Oops you're right! No idea why I did that. :-)
|
|
Assignee | |
Comment 6•13 years ago
|
||
|
||
Comment 7•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•