Closed Bug 907925 Opened 6 years ago Closed 6 years ago

Add reasons to Marionette's wait_for_port() assertions, to make them TBPL compatible

Categories

(Testing :: Marionette, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: emorley, Assigned: emorley)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We should add a reason to the several "assert(self.emulator.wait_for_port())"s in marionette.py [1], since:
a) It's nice to have a reason.
b) TBPL's regex looks for the semicolon [2], so without the reason the parser doesn't pick them up, meaning one has to manually look at the log (eg bug 905324).

[1] http://hg.mozilla.org/mozilla-central/file/ba6c02fc1fe6/testing/marionette/client/marionette/marionette.py#l459
[2] https://hg.mozilla.org/webtools/tbpl/file/a450877aae00/php/inc/GeneralErrorFilter.php#l47
Attached patch Patch v1Splinter Review
Attachment #793693 - Flags: review?(jgriffin)
Summary: Add a reason to marionette.py's "assert(self.emulator.wait_for_port())" so the TBPL parser sees them → Add reasons to Marionette's wait_for_port() assertions, to make them TBPL compatible
Comment on attachment 793693 [details] [diff] [review]
Patch v1

Review of attachment 793693 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
Attachment #793693 - Flags: review?(jgriffin) → review+
Thank you for the quick review :-)

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/f73c3aaafc1b
https://hg.mozilla.org/mozilla-central/rev/f73c3aaafc1b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.