90794 - Windows integration registry key not properly installed/removed

Status: RESOLVED WONTFIX

(Core :: Preferences: Backend, defect, P3)

Description

[Dimitrios]

Build 2001071004, Win98SE

When Mozilla is not configured to be the default html viewer
(Prefs->Advanced-System), I cannot find "Mozilla" item in the "Open With"
Windows file context menu dialog. This makes life a bit more difficult, when I
want to selectively open a file with Mozilla instead using with my default browser
The Windows registry key is: HKEY_CLASSES_ROOT - MozillaHTML - shell - open -
command

I would expect this key to be removed only when Mozilla is uninstalled.

Steps to reproduce:
1. Be sure you have defined Mozilla as the main browser for handling html documents
2. From Explorer, select a html file, keep shift button depressed and with the
right mouse button select "Open with". A "Mozilla" item is here and choosing it
opens the document.
3. Now install Mozilla without making it the default browser or simply go to
Prefs->Advanced-System and uncheck "html documents" option.
4. Repeat step 2. 

Expected results:
Mozilla item still exists in "Open With" dialog

Actual results:
Mozilla item (see registry key above) is absent.

Comment 1

[Brian Nesse (gone)]

My best guess is that this is an installation issue... It's certainly not
Preferences.

Comment 2

[Sean Su]

This is not an installer problem.  The installer does not set the browser as the 
default html handler.  Mozilla does that itself at startup.

This is Bill Law's code.

Comment 3

[Daniel Veditz [:dveditz]]

CC'ing a few folks since law is on sabbatical. This is basically the same kind 
of thing as bug 90071 except browser rather than mail. If either this or bug 
90071 get fixed the uninstall code will have to know about it (as with the 
other desktop integration options), but the actual setting is done in the 
product itself.

Comment 4

[sairuh (rarely reading bugmail)]

blake, could you take this while bill is gone?

Comment 5

[Viswanath Ramachandran]

-> moving to law, mozilla0.9.5. 

Comment 6

[Bill Law]

I don't think we've ever done anything to get Mozilla on the "Open With" list
for anything.  That would require some additional registry hacking beyond what
we do currently.  I don't think this feature will be doable for mozilla0.9.5
unless somebody can specify precisely what registry keys need to be set to what
values to make this work.  This isn't high enough priority to cause me to figure
that out right now.

Comment 7

[Dimitrios]

First of all, Mozilla *does* create registry entry for "Open with" list (see key
below).

I installed Mozilla with the option to become the default application for html
documents. Then I unchecked this option in Prefs->Advanced->System. Attaching
file containing the differences in registry for the above two steps.

The change that produces this bug is the deletion of key
HKEY_LOCAL_MACHINE\Software\Mozilla\Desktop
that contains the value with name
HKEY_LOCAL_MACHINE\Software\Classes\MozillaHTML\shell\open\command
and data 
PROGRA~1\MOZILLA.ORG\MOZILLA\MOZILLA.EXE -url "%1" 

This is item 6 in the attached file. Bug is resolved if I manually insert the
above key+value+value data in registry. Thus, this bug will be fixed if the
above key is deleted *only* when Mozilla is uninstalled.

Besides this, of particular importance is item 6, i.e. the modification of
HKEY_LOCAL_MACHINE\Software\CLASSES\MozillaHTML\shell\open\command key. I don't
understand why "C:\" is removed from the path. I think this key should be left
intact.

Comment 8

[Dimitrios]

Attachment: Changes to the registry after preventing Mozilla from being the default application for html documents

Comment 9

[Bill Law]

Resetting target milestone for all "window integration" bugs to mozilla0.9.8.  
I'm working on performance and won't get to that till next milestone.

Comment 10

[Bill Law]

Not getting to this, either.

Comment 11

[:deanis74]

dupe of bug 97765?

Comment 12

[Bill Law]

Spam: Moving out bugs that there is no time for.

Please note that some of these will hopefully be fixed in the course of fixing 
bug 59078.  I just can't commit to fixing them all.

Comment 13

[Terri Preston]

Changing qa contact to me, as I am working on these now ;-)

Comment 14

[Mark Hammond [:markh] [:mhammond]]

This is not a dupe of bug 97765 - 97765 states that when you set Mozilla as the
default for HTML files, all existing HTML commands that were setup are lost (ie,
the right-click menu for a HTML file from Windows Explorer).

I can confirm comment #7 From Dimitrios Papadopoulos - The MozillaHTML key
should remain in place even when not the default.

I will have a look at this.

Comment 15

[Mark Hammond [:markh] [:mhammond]]

Attaching a patch for this.  It allows a FileTypeRegistryEntry to become
"sticky", and exist even when no extensions are mapped to it.

|mozillaMarkup| is the only object changed to be sticky - the "MozillaHTML"
entry is always added to the registry.

The end result is that the Windows "Open With..." dialog always shows Mozilla,
even when Mozilla is not the default browser. 

Comment 16

[Mark Hammond [:markh] [:mhammond]]

Attachment: Patch so "Open With" dialog always lists Mozilla

Comment 17

[Ioana (away)]

Windows 98 support has been dropped a long while ago. Please only reopen this bug if you can reproduce it on Windows XP or older with current Firefox builds.