907949 - Collection creation fails with 'slug [ "This field is required." ]'

Status: VERIFIED FIXED

(Marketplace Graveyard :: Admin Tools, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/curation/new_collection?type=basic
2. Try to make a collection with the name アドオンを探す or Más

expected behavior:
We allow collections with localized strings in their names to be created

observed behavior:
Collection creation fails with a 400

[15:00:56.076] POST https://marketplace-dev.allizom.org/api/v1/rocketfuel/collections/?_user=&lang=en-US&region=worldwide [HTTP/1.1 400 BAD REQUEST 137ms]

Comment 1

[krupa raj[:krupa]]

So, this is happening with all collections. Nothing to do with unicode. Updated the bug summary.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

We need to add a "Slug" field that gets slugified onkeypress from the "Name" field.
We should also disable the "Create" button if the form is incomplete/invalid.

Comment 3

[Chuck Harmston [:chuck]]

@cvan: Any reason not to to autogenerate a slug if one isn't provided?

Comment 4

[Chuck Harmston [:chuck]]

PR for the potential approach suggested in comment 3: https://github.com/mozilla/zamboni/pull/1032

Comment 5

[Matt Basta [:basta]]

I'll push my updates tomorrow that add a slug field to the New Collection page. That will fix this error. I'd rather have an autogenerated slug that the client has seen than one that turns out to be a surprise. Let me know if you disagree.

Either way, the PR you have looks good and there's no reason we can't have both.

Comment 6

[Chuck Harmston [:chuck]]

Landed that PR here: https://github.com/mozilla/zamboni/compare/5761699e2b95...fd29c960b5e5

@basta: resolve this bug when your updates land?

Comment 7

[Matt Basta [:basta]]

Will do. I'm in the process of updating our forms code for new styles as well as better validation support (turning the control borders red on error) and `add -p`-ing the slug stuff might be tricky. I should have it ready by EOD.

Comment 8

[Matt Basta [:basta]]

Should be landed.

Comment 9

[krupa raj[:krupa]]

verified fixed