907961 - F12 in Detached Devtools Window should close it

Status: RESOLVED DUPLICATE of bug 999568

(DevTools :: Framework, enhancement)

Description

[Brandon Benvie [:benvie]]

F12 in detached devtools window currently does nothing. It should follow the behavior of the docked devtools and close itself.

Comment 1

[Julian Descottes]

Can I be assigned to this bug ? 

I am working on https://bugzilla.mozilla.org/show_bug.cgi?id=999568 (F12 should bring devtools to the foreground). It would be nice to implement this one as well, since they are functionally related.

Comment 2

[Julian Descottes]

Attachment: bug907961.patch

Added new entity for F12 in toolbox.dtd.
Added new key in toolbox-keyset in toolbox-window.xul (should not interfere with
F12 defined in main window)

For the tests I would like to merge the test for this one and for bug 999568 and generate keyboard events. 

@patrick : Should we merge the issues and only work in bug 999568 ?

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8597846 [details] [diff] [review]
bug907961.patch

Review of attachment 8597846 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great.
The only thing is that there's a second way to toggle the devtools:
alt-cmd-I (on Mac, and whatever is equivalent on Windows).
See: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sets.inc#311

Comment 4

[Patrick Brosset <:pbro>]

(In reply to julian.descottes from comment #2)
> For the tests I would like to merge the test for this one and for bug 999568
> and generate keyboard events. 
> 
> @patrick : Should we merge the issues and only work in bug 999568 ?
Sure, fine with me. These issues are sufficiently related that we can tackle both in just one bug, especially if it makes more sense for you to write the test(s).
I'll mark this one as duplicate of the other, and copy the description over.