Closed Bug 907965 Opened 8 years ago Closed 8 years ago

[Gallery] Rotate preview and thumbnail if image has orientation metadata

Categories

(Firefox OS Graveyard :: Gaia::Gallery, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: heroldtom, Assigned: heroldtom)

References

Details

Attachments

(2 files)

Image are rotated in the fullscreen view of the gallery if there is orientation metadata (EXIF) present. See Bug 900425.

Preview images and thumbnails are still displayed without any rotation. The have to be created with orientation in mind.
Assignee: nobody → therold
Depends on: 900425
I think only the thumbnail needs to be rotated. 

The preview should look just like a smaller version of the full-size image.  The rotation should happen when the preview is displayed, not when it is created.
Attachment #800483 - Flags: review?(dflanagan)
Comment on attachment 800483 [details]
Link to Github pull request

There are a few nits to address on github. But if you fix those, and if you've tested carefully, then you can land this.

When testing, use the set of 16 pictures you linked to in the other bug, of course.

But also please test videos recorded on the device (recording in all four possible orientations) so we verify that video thumbnails are being created correctly.
Attachment #800483 - Flags: review?(dflanagan) → review+
More exif test images can be found at: https://github.com/recurser/exif-orientation-examples
I tested all the test images mentioned above on a geeksphone keon and thumbnails worked perfectly. I took 4 videos (1 for each orientation) and all of them had the right thumbnails too. However, I was unable to play the videos within the gallery app (video app works fine). I suppose this is not related to this bug however.

@djf: Unless you want me to wrap the translate calls within if statements this is done.
I tried the patch on a different phone and the video issue with the gallery is not related to this phone.
Landed on master: https://github.com/mozilla-b2g/gaia/commit/3628d9f5829f087782c708981c4863a7d885a96a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.