907965 - [Gallery] Rotate preview and thumbnail if image has orientation metadata

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Tom Herold]

Image are rotated in the fullscreen view of the gallery if there is orientation metadata (EXIF) present. See Bug 900425.

Preview images and thumbnails are still displayed without any rotation. The have to be created with orientation in mind.

Comment 1

[David Flanagan [:djf]]

I think only the thumbnail needs to be rotated. 

The preview should look just like a smaller version of the full-size image.  The rotation should happen when the preview is displayed, not when it is created.

Comment 2

[Tom Herold]

Attachment: Link to Github pull request

Comment 3

[David Flanagan [:djf]]

Comment on attachment 800483 [details]
Link to Github pull request

There are a few nits to address on github. But if you fix those, and if you've tested carefully, then you can land this.

When testing, use the set of 16 pictures you linked to in the other bug, of course.

But also please test videos recorded on the device (recording in all four possible orientations) so we verify that video thumbnails are being created correctly.

Comment 4

[Tom Herold]

Attachment: testimage_very_small.jpg

Comment 5

[Tom Herold]

More exif test images can be found at: https://github.com/recurser/exif-orientation-examples

Comment 6

[Tom Herold]

I tested all the test images mentioned above on a geeksphone keon and thumbnails worked perfectly. I took 4 videos (1 for each orientation) and all of them had the right thumbnails too. However, I was unable to play the videos within the gallery app (video app works fine). I suppose this is not related to this bug however.

@djf: Unless you want me to wrap the translate calls within if statements this is done.

Comment 7

[Tom Herold]

I tried the patch on a different phone and the video issue with the gallery is not related to this phone.

Comment 8

[David Flanagan [:djf]]

Landed on master: https://github.com/mozilla-b2g/gaia/commit/3628d9f5829f087782c708981c4863a7d885a96a