Closed
Bug 907971
Opened 11 years ago
Closed 11 years ago
nsIAlarmHalService shouldn't be builtinclass
Categories
(Core :: Hardware Abstraction Layer (HAL), defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file)
1.07 KB,
patch
|
airpingu
:
review+
|
Details | Diff | Splinter Review |
nsIAlarmHalService is currently builtinclass and in b2g that makes sense. However, for b2g-desktop, we have the browser-helper extension that replaces certain services with JS-implemented versions and one of them needs to implement nsIAlarmHalService. I believe that this effectively causes the DOM alarm service to not work, at the very least causing b2g to fail to startup (due to thrown exceptions) on first run.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #793743 -
Flags: review?(gene.lian)
Comment 2•11 years ago
|
||
Comment on attachment 793743 [details] [diff] [review] patch v1 Review of attachment 793743 [details] [diff] [review]: ----------------------------------------------------------------- r=gene. Thanks! Btw, do we need to update the uuid?
Attachment #793743 -
Flags: review?(gene.lian) → review+
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Gene Lian [:gene] from comment #2) > Btw, do we need to update the uuid? It wouldn't have hurt, but given that this change doesn't affect the vtable, it's not necessary.
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e72315ff9b0f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•