907971 - nsIAlarmHalService shouldn't be builtinclass

Status: RESOLVED FIXED

(Core :: Hardware Abstraction Layer (HAL), defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

nsIAlarmHalService is currently builtinclass and in b2g that makes sense. However, for b2g-desktop, we have the browser-helper extension that replaces certain services with JS-implemented versions and one of them needs to implement nsIAlarmHalService.

I believe that this effectively causes the DOM alarm service to not work, at the very least causing b2g to fail to startup (due to thrown exceptions) on first run.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

Comment 2

[Gene Lian (I already quit Mozilla)]

Comment on attachment 793743 [details] [diff] [review]
patch v1

Review of attachment 793743 [details] [diff] [review]:
-----------------------------------------------------------------

r=gene. Thanks!

Btw, do we need to update the uuid?

Comment 3

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/b2g-inbound/rev/e72315ff9b0f

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to Gene Lian [:gene] from comment #2)
> Btw, do we need to update the uuid?

It wouldn't have hurt, but given that this change doesn't affect the vtable, it's not necessary.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e72315ff9b0f