907974 - Notes for reviewers not showing up in the communication dashboard

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: Developer Pages, defect, P3)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Submit a packaged app
2. After submission, go to https://marketplace-dev.allizom.org/developers/app/test-large-web-packaged-app-1/versions/1455193 and add Notes to reviewers and save changes
3. Check if your Note shows up in the /comm dashboard @ https://marketplace-dev.allizom.org/comm/
4. As a reviewer, load https://marketplace-dev.allizom.org/reviewers/apps/review/test-large-web-packaged-app-1 and notice the notes to reviewers is listed in the review details page
5. Now load the https://marketplace-dev.allizom.org/comm/ and see if the note shows up for reviewers.



observed behavior:
Note to reviewers added immediately after submission is not showing up for both the developer and the reviewer.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Ashish, I don't see it either. As I'm a reviewer on -dev, shouldn't I also see it on my /comm/ listing of threads?

Comment 2

[Ashish Dubey [:ashish_d]]

Hmm, this looks like a bug with the API. I did a 'Request information' from Reviewer tools and the note shows up.

Comment 3

[Ashish Dubey [:ashish_d]]

A thing to note is, you'd see the threads only if you've posted to them before (if you're a reviewer).

(In reply to Christopher Van Wiemeersch [:cvan] from comment #1)
> Ashish, I don't see it either. As I'm a reviewer on -dev, shouldn't I also
> see it on my /comm/ listing of threads?

Comment 4

[krupa raj[:krupa]]

Attachment: reviewer note missing from the comm.png

I can still reproduce this issue. I cannot see the reviewer note even while logged in as the developer who added it. The screenshot shows that the new app to which the reviewer note is added is not listed in the communication dashboard.

Comment 5

[Ashish Dubey [:ashish_d]]

fixed https://github.com/mozilla/zamboni/commit/6bfad5

Comment 6

[Victor Carciu]

Now, I am able to see the note for reviewers if logged as the developer, but on reviewer side , the notes are not listed in communication dashboard. I added a screencast where first comm dashboard view is from developer side and the second one from reviewers side : http://screencast.com/t/FBUS2mpjqF

Comment 7

[Kevin Ngo [:ngoke]]

It works for me. Here is what I tried:

DEVELOPER:

1. Submit a packaged app.
2. Make a note to reviewers in the Versions page.
3. Check the communication dashboard, the note is there.

REVIEWER:

1. Go to the app's review page.
2. The note is there.
3. Push the app to public, leaving a note.
4. Check the communication dashboard, the note to reviewers is there and the approve note is there.

If it does not work, can you give me specific steps to reproduce after Ashish's last commit?

Comment 8

[Victor Carciu]

(In reply to Kevin Ngo [:ngoke] from comment #7)
> It works for me. Here is what I tried:
> 
> DEVELOPER:
> 
> 1. Submit a packaged app.
> 2. Make a note to reviewers in the Versions page.
> 3. Check the communication dashboard, the note is there.
> 
> REVIEWER:
> 
> 1. Go to the app's review page.
> 2. The note is there.
> 3. Push the app to public, leaving a note.
> 4. Check the communication dashboard, the note to reviewers is there and the
> approve note is there.
> 
> If it does not work, can you give me specific steps to reproduce after
> Ashish's last commit?


Now it is working for me too , can we close it?