907988 - Editing a bookmark does not update the item in view in the bookmarks tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Aaron Train [:aaronmt]]

Currently one can edit a bookmark (long-tap, edit) and any changes made are not shown in the listed item in the bookmarks tab on about:home. The view needs to be updated to reflect any changes.

One can confirm that changes are saved fine by querying for the
--
Nightly (08/21)

Comment 1

[Aaron Train [:aaronmt]]

.. bookmark in the address-bar or via adding it as a thumbnail.

Comment 2

[Sriram Ramasubramanian [:sriram]]

I am unable to reproduce this. I changed the title and could see it reflected in the list.

Comment 3

[Aaron Train [:aaronmt]]

Try synced bookmarks? I can reproduce on those. I'm also renaming the bottom-most bookmark in the list and that doesn't work for me.

Using a Nexus 4 (4.3) and Galaxy SIV (4.3) same results, haven't tried any other device.

Comment 4

[Aaron Train [:aaronmt]]

Video!

http://www.youtube.com/watch?v=J5lqDLurLB0

Comment 5

[Sriram Ramasubramanian [:sriram]]

This happens when there are multiple entries with the same URL. When you long press and try to edit the last entry, the first entry having the same url is edited. We probably need some sort of filtering I guess.

@margaret: What shall we do here?

Comment 6

[:Margaret Leibovic]

(In reply to Sriram Ramasubramanian [:sriram] from comment #5)
> This happens when there are multiple entries with the same URL. When you
> long press and try to edit the last entry, the first entry having the same
> url is edited. We probably need some sort of filtering I guess.
> 
> @margaret: What shall we do here?

I'd need to look into this more, but it sounds like we're using the wrong update query to edit the bookmark. We should update based on the bookmark id, and it sounds like we're just updating based on the URL.

Comment 7

[Wesley Johnston (:wesj)]

Note, I added the ability to edit based on URL for the super toast option (i.e. we don't know which bookmark associated with this url is being editing in that case). Maybe we'd be better to allow editing a "group" of bookmarks in that case.

I think the only reason we allow multiple bookmarks with one url is when you've pinned something?

Comment 8

[Sriram Ramasubramanian [:sriram]]

Multiple bookmarks with same url happens when you sync.

Comment 9

[Aaron Train [:aaronmt]]

... I don't have a duplicate bookmark?

Comment 10

[Sriram Ramasubramanian [:sriram]]

I could reproduce it only with duplicate bookmarks.

Comment 11

[Sriram Ramasubramanian [:sriram]]

Is this reproducible with non-duplicate entries?

Comment 12

[Aaron Train [:aaronmt]]

Nope.

Comment 13

[Lucas Rocha (:lucasr)]

Seems to be fixed with the patches in bug 917455.

Comment 14

[Lucas Rocha (:lucasr)]

Bug 917455 has landed in m-c now. Closing.

Comment 15

[Lucas Rocha (:lucasr)]

Bug 917455 has been uplifted to Aurora.